From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: "Nilawar, Badal" <badal.nilawar@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Don't enable hwmon for selftests
Date: Tue, 09 Apr 2024 23:06:58 -0700 [thread overview]
Message-ID: <85seztkayl.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <1e16a3a8-81e2-4214-a07c-74922627f232@intel.com>
On Tue, 09 Apr 2024 22:17:38 -0700, Nilawar, Badal wrote:
>
> > +#if IS_ENABLED(CONFIG_DRM_I915_SELFTEST)
> > + return i915_selftest.live || i915_selftest.perf || i915_selftest.mock;
> > +#else
> > + return false;
> > +#endif
> > +}
> I think you moved this function here as this is only used in
> i915_hwmon.c. In case if somewhere else this function is needed then I
> suggest to move this function to i915_selftest.h as inline function.
Thanks, done in v3.
next prev parent reply other threads:[~2024-04-10 6:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 4:58 [PATCH] drm/i915: Don't enable hwmon for selftests Ashutosh Dixit
2024-04-10 5:17 ` Nilawar, Badal
2024-04-10 6:06 ` Dixit, Ashutosh [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-04-10 20:07 Ashutosh Dixit
2024-04-10 6:05 Ashutosh Dixit
2024-04-10 6:45 ` Nilawar, Badal
2024-04-10 13:53 ` Andi Shyti
2024-04-11 4:59 ` Dixit, Ashutosh
2024-04-10 4:28 Ashutosh Dixit
2024-04-10 4:37 ` Dixit, Ashutosh
2024-04-10 4:56 ` Nilawar, Badal
2024-04-10 11:42 ` Ville Syrjälä
2024-04-11 5:09 ` Dixit, Ashutosh
2024-04-11 10:47 ` Ville Syrjälä
2024-04-13 0:35 ` Dixit, Ashutosh
2024-04-13 0:37 ` Dixit, Ashutosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85seztkayl.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=badal.nilawar@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox