From: Keith Packard <keithp@keithp.com>
To: intel-gfx@lists.freedesktop.org
Cc: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 1/2] drm/i915: argument for deferring retirement
Date: Tue, 24 Jan 2012 15:00:05 -0800 [thread overview]
Message-ID: <86liowln9m.fsf@sumi.keithp.com> (raw)
In-Reply-To: <1327444923-13316-1-git-send-email-ben@bwidawsk.net>
[-- Attachment #1.1: Type: text/plain, Size: 562 bytes --]
On Tue, 24 Jan 2012 14:42:02 -0800, Ben Widawsky <ben@bwidawsk.net> wrote:
> Sometimes it may be the case when we idle the gpu or wait on something
> we don't actually want to process the retiring list. This patch allows
> callers to choose the behavior.
<bikeshed>
!defer_retirement sounds like a double-negative to me, might be better
to have the parameter called 'do_retire' and change usage to match?
</bikeshed>
In any case, this looks easy to understand to me.
Reviewed-by: Keith Packard <keithp@keithp.com>
--
keith.packard@intel.com
[-- Attachment #1.2: Type: application/pgp-signature, Size: 827 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2012-01-24 23:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-24 22:42 [PATCH 1/2] drm/i915: argument for deferring retirement Ben Widawsky
2012-01-24 22:42 ` [PATCH 2/2] drm/i915: drm/i915: Fix recursive calls to unmap Ben Widawsky
2012-01-24 23:00 ` Keith Packard
2012-01-25 4:02 ` Ben Widawsky
2012-01-25 15:50 ` Keith Packard
2012-01-24 23:00 ` Keith Packard [this message]
2012-01-24 23:05 ` [PATCH 1/2] drm/i915: argument for deferring retirement Eugeni Dodonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86liowln9m.fsf@sumi.keithp.com \
--to=keithp@keithp.com \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox