From: Keith Packard <keithp@keithp.com>
To: Daniel Vetter <daniel@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel.vetter@intel.com>,
intel-gfx <intel-gfx@lists.freedesktop.org>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 2/2] drm/i915: Drop reference to current state wait req as soon as it goes unused
Date: Mon, 08 Aug 2016 08:49:07 -0700 [thread overview]
Message-ID: <86oa53jm6k.fsf@hiro.keithp.com> (raw)
In-Reply-To: <CAKMK7uFWga4UfsghcKAHrH3kaa5+rMKygDQZ2COqRS06FqTevg@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 660 bytes --]
Daniel Vetter <daniel@ffwll.ch> writes:
> We still need to clean up the reference in case of failure, which
> means latest in intel_plane_destroy_state(). Also hanging onto a
> request isn't that evil really, why can't we just only clean up in the
> destroy function?
Sticking a cleanup there as well is good insurance, but it seems like a
reasonable policy to drop references when values go 'out of scope' as
they do in cleanup_plane_fb. But, you're right, we only *need* to drop
the reference in the destroy function, it's just that the state hangs
around until the next mode setting operation, which is likely to be days
away.
--
-keith
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 810 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-08-08 15:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-08 11:23 [PATCH 0/2] drm/i915: Fix wait_req unreferencing Maarten Lankhorst
2016-08-08 11:23 ` [PATCH 1/2] drm/i915: Remove early return in prepare/cleanup plane Maarten Lankhorst
2016-08-08 11:23 ` [PATCH 2/2] drm/i915: Drop reference to current state wait req as soon as it goes unused Maarten Lankhorst
2016-08-08 15:34 ` Daniel Vetter
2016-08-08 15:49 ` Keith Packard [this message]
2016-08-09 10:15 ` [PATCH 2/2] drm/i915: Drop reference to plane state wait req in destructor Maarten Lankhorst
2016-08-09 11:20 ` Daniel Vetter
2016-08-09 9:18 ` [PATCH 2/2] drm/i915: Drop reference to current state wait req as soon as it goes unused Maarten Lankhorst
2016-08-08 11:25 ` ✗ Ro.CI.BAT: failure for drm/i915: Fix wait_req unreferencing Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86oa53jm6k.fsf@hiro.keithp.com \
--to=keithp@keithp.com \
--cc=airlied@linux.ie \
--cc=daniel.vetter@intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox