Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Packard <keithp@keithp.com>
To: Daniel Vetter <daniel@ffwll.ch>, Wu Fengguang <fengguang.wu@intel.com>
Cc: Takashi Iwai <tiwai@suse.de>,
	"intel-gfx@lists.freedesktop..."
	<intel-gfx@lists.freedesktop.org>, Michal Marek <mmarek@suse.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Robert Lemaire <rlemaire@suse.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: set AUD_CONFIG N_value_index for DisplayPort
Date: Mon, 16 Jan 2012 12:44:43 -0800	[thread overview]
Message-ID: <86obu31io4.fsf@sumi.keithp.com> (raw)
In-Reply-To: <20120116202618.GG3627@phenom.ffwll.local>

[-- Attachment #1: Type: text/plain, Size: 441 bytes --]

On Mon, 16 Jan 2012 21:26:18 +0100, Daniel Vetter <daniel@ffwll.ch> wrote:

> Keith, does this address your concern and this patch is r-b: Keith or do
> we want an
> 
> } else {
> 	I915_WRITE(aud_config, 0);
> }
> 
> for paranoia?

I think we want this added, just to be sure we set the configuration
correctly in all cases; it's easy to imagine moving from DP to HDMI and
leaving this bit set.

-- 
keith.packard@intel.com

[-- Attachment #2: Type: application/pgp-signature, Size: 827 bytes --]

  reply	other threads:[~2012-01-16 20:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-09 13:17 [PATCH] drm/i915: set AUD_CONFIG N_value_index for DisplayPort Wu Fengguang
2012-01-09 17:22 ` Keith Packard
2012-01-10  5:45   ` Wu Fengguang
2012-01-12 17:33     ` Keith Packard
2012-01-16  8:02       ` Wu Fengguang
2012-01-16 20:26         ` Daniel Vetter
2012-01-16 20:44           ` Keith Packard [this message]
2012-01-16 23:08             ` [Intel-gfx] " Wu Fengguang
2012-01-16 23:15               ` Keith Packard
2012-01-17 10:22               ` [Intel-gfx] " Daniel Vetter
2012-01-29  4:44                 ` [PATCH][rebased] " Wu Fengguang
2012-01-29 12:12                   ` Daniel Vetter
2012-01-29 13:23                     ` Wu Fengguang
2012-01-29 15:14                       ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86obu31io4.fsf@sumi.keithp.com \
    --to=keithp@keithp.com \
    --cc=daniel@ffwll.ch \
    --cc=fengguang.wu@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.com \
    --cc=rlemaire@suse.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox