From: Jani Nikula <jani.nikula@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Restrict DRM_I915_DEBUG to developer builds
Date: Fri, 22 Jan 2021 11:43:25 +0200 [thread overview]
Message-ID: <871redl32a.fsf@intel.com> (raw)
In-Reply-To: <874kj9l3f5.fsf@intel.com>
On Fri, 22 Jan 2021, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Fri, 22 Jan 2021, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>> Let's not encourage everybody to build i915's debug code, and certainly
>> not the build robots who need to scrutinise the production build. Since
>> CI will complain if the debug build is broken, having the other build
>> bots focus on the builds we don't cover ourselves should improve the
>> build coverage.
>
> I don't disagree with this, although I wrote in another mail that I'm
> not sure DRM_I915_DEBUG should select DRM_I915_WERROR. I think they
> should be two separate things.
>
> Even so, for this change,
>
> Acked-by: Jani Nikula <jani.nikula@intel.com>
Musing, a compile test could still enable all the individual knobs in
Kconfig.debug, right?
How would this work in Kconfig?
+if DRM_I915 && EXPERT && !COMPILE_TEST
menu "drm/i915 Debugging"
-depends on DRM_I915
-depends on EXPERT
source "drivers/gpu/drm/i915/Kconfig.debug"
endmenu
+endif
BR,
Jani.
>
>>
>> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
>> Fixes: 4f86975f539d ("drm/i915: Add DEBUG_GEM to the recommended CI config")
>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>> ---
>> drivers/gpu/drm/i915/Kconfig.debug | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug
>> index e2d33f1abb3d..5b457fb2d268 100644
>> --- a/drivers/gpu/drm/i915/Kconfig.debug
>> +++ b/drivers/gpu/drm/i915/Kconfig.debug
>> @@ -19,6 +19,8 @@ config DRM_I915_WERROR
>> config DRM_I915_DEBUG
>> bool "Enable additional driver debugging"
>> depends on DRM_I915
>> + depends on EXPERT # only for developers
>> + depends on !COMPILE_TEST # never built by robots
>> select PCI_MSI # ... for iommu enabled by default
>> select IOMMU_API
>> select IOMMU_IOVA
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-01-22 9:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 9:10 [Intel-gfx] [PATCH] drm/i915: Restrict DRM_I915_DEBUG to developer builds Chris Wilson
2021-01-22 9:35 ` Jani Nikula
2021-01-22 9:39 ` Chris Wilson
2021-01-22 9:43 ` Jani Nikula [this message]
2021-01-22 15:53 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871redl32a.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox