From: Jani Nikula <jani.nikula@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915: switch vlv_suspend to use intel uncore register accessors
Date: Mon, 17 Feb 2020 11:36:59 +0200 [thread overview]
Message-ID: <871rqtwo5g.fsf@intel.com> (raw)
In-Reply-To: <158163713950.4660.5341490618839546150@skylake-alporthouse-com>
On Thu, 13 Feb 2020, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Jani Nikula (2020-02-12 14:40:58)
>> Prefer intel_uncore_* over I915_READ, I915_WRITE, and POSTING_READ.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> A couple of older checkpatch errors that could be cleaned up (pure
> whitespacing).
>
> Both
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Thanks, pushed with one space added to the 2nd patch to silence the
checkpatch.
> Half this code should be removed as we explicitly reset the registers on
> resume. (And if we need to add a few special runtime-resume hooks, would
> not be a bad thing). And the other half, probably should be removed with
> a bit of extra work.
It's been rainy lately, but I guess I'll be waiting for a rainier day
yet to embark on that. ;)
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-02-17 9:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 14:40 [Intel-gfx] [PATCH 1/2] drm/i915: split out vlv/chv specific suspend/resume code Jani Nikula
2020-02-12 14:40 ` [Intel-gfx] [PATCH 2/2] drm/i915: switch vlv_suspend to use intel uncore register accessors Jani Nikula
2020-02-13 23:38 ` Chris Wilson
2020-02-17 9:36 ` Jani Nikula [this message]
2020-02-13 2:16 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: split out vlv/chv specific suspend/resume code Patchwork
2020-02-13 2:41 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-02-16 7:41 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rqtwo5g.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox