From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915/selftests: Drop unnecessary struct_mutex around i915_reset()
Date: Fri, 15 Feb 2019 17:42:43 +0200 [thread overview]
Message-ID: <871s49ys5o.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <155024453481.18261.15466118741787809297@skylake-alporthouse-com>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> Quoting Mika Kuoppala (2019-02-15 15:21:11)
>> Chris Wilson <chris@chris-wilson.co.uk> writes:
>>
>> > Since we no longer need to hold struct_mutex to perform a global device
>> > reset, don't do so for igt_reset_wedge().
>> >
>>
>> Oh but the interesting question is not about need, but should =)
>> Do it both ways?
>
> Just doing it without should be enough for lockdep, and specifically
> remember to guard everything with lockdep_assert_held() when required.
> The reverse case of testing with it held can only prove a deadlock by
> hitting it! (At which point CI reboots the machine.)
Not much value to prove that the old model works with new rules,
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-02-15 15:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 10:27 [PATCH 1/2] drm/i915/selftests: Exercise resetting during non-user payloads Chris Wilson
2019-02-15 10:27 ` [PATCH 2/2] drm/i915/selftests: Drop unnecessary struct_mutex around i915_reset() Chris Wilson
2019-02-15 15:21 ` Mika Kuoppala
2019-02-15 15:28 ` Chris Wilson
2019-02-15 15:42 ` Mika Kuoppala [this message]
2019-02-15 15:18 ` [PATCH 1/2] drm/i915/selftests: Exercise resetting during non-user payloads Mika Kuoppala
2019-02-15 15:33 ` Chris Wilson
2019-02-15 17:35 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] " Patchwork
2019-02-15 18:11 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-02-15 18:41 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871s49ys5o.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox