From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: imre.deak@intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Show dmc debug registers on Kabylake
Date: Tue, 09 May 2017 16:16:12 +0300 [thread overview]
Message-ID: <871srymaqr.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20170509101550.GA30246@ideak-desk.fi.intel.com>
Imre Deak <imre.deak@intel.com> writes:
> On Tue, May 09, 2017 at 01:05:22PM +0300, Mika Kuoppala wrote:
>> The assumption is that the registers offsets are
>> identical as with skl. Also all the published
>> kbl firmwares support the debug registers. So
>> let kbl show the debug counts.
>>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100975
>> Cc: Imre Deak <imre.deak@intel.com>
>> Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
>
> Reviewed-by: Imre Deak <imre.deak@intel.com>
Pushed. Thanks for review!
-Mika
>
>> ---
>> drivers/gpu/drm/i915/i915_debugfs.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
>> index 1003511..34785fb 100644
>> --- a/drivers/gpu/drm/i915/i915_debugfs.c
>> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
>> @@ -2853,7 +2853,8 @@ static int i915_dmc_info(struct seq_file *m, void *unused)
>> seq_printf(m, "version: %d.%d\n", CSR_VERSION_MAJOR(csr->version),
>> CSR_VERSION_MINOR(csr->version));
>>
>> - if (IS_SKYLAKE(dev_priv) && csr->version >= CSR_VERSION(1, 6)) {
>> + if (IS_KABYLAKE(dev_priv) ||
>> + (IS_SKYLAKE(dev_priv) && csr->version >= CSR_VERSION(1, 6))) {
>> seq_printf(m, "DC3 -> DC5 count: %d\n",
>> I915_READ(SKL_CSR_DC3_DC5_COUNT));
>> seq_printf(m, "DC5 -> DC6 count: %d\n",
>> --
>> 2.7.4
>>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-05-09 13:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-09 10:05 [PATCH] drm/i915: Show dmc debug registers on Kabylake Mika Kuoppala
2017-05-09 10:15 ` Imre Deak
2017-05-09 13:16 ` Mika Kuoppala [this message]
[not found] ` <20170510020358.GA2292@nc-int>
2017-05-10 8:01 ` Mika Kuoppala
2017-05-09 10:22 ` ✓ Fi.CI.BAT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871srymaqr.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox