From: Jani Nikula <jani.nikula@intel.com>
To: Zhenyu Wang <zhenyuw.linux@gmail.com>
Cc: intel-gfx@lists.freedesktop.org,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Subject: Re: [RESEND] drm/i915/gvt: use hardcoded reference clocks
Date: Tue, 01 Apr 2025 11:58:21 +0300 [thread overview]
Message-ID: <8734es45si.fsf@intel.com> (raw)
In-Reply-To: <Z-lYh8toArVVUZgC@dell-wzy>
On Sun, 30 Mar 2025, Zhenyu Wang <zhenyuw.linux@gmail.com> wrote:
> On Fri, Mar 21, 2025 at 02:51:14PM +0200, Jani Nikula wrote:
>> Usually I'd argue hardcoding values is the wrong thing to do, but in
>> this case, GVT looking deep into the guts of the DPLL manager for the
>> reference clocks is worse. This is done for BDW and BXT only, and there
>> shouldn't be any reason to try to be so dynamic about it.
>>
>> This helps reduce the direct pokes at display guts from non-display
>> code.
>>
>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> Reviewed-by: Zhenyu Wang <zhenyuw.linux@gmail.com>
Thanks, pushed to drm-intel-next.
BR,
Jani.
--
Jani Nikula, Intel
prev parent reply other threads:[~2025-04-01 8:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-21 12:51 [RESEND] drm/i915/gvt: use hardcoded reference clocks Jani Nikula
2025-03-21 13:39 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gvt: use hardcoded reference clocks (rev3) Patchwork
2025-03-21 13:39 ` ✗ Fi.CI.SPARSE: " Patchwork
2025-03-21 13:39 ` ✗ Fi.CI.DOCS: " Patchwork
2025-03-21 14:03 ` ✓ i915.CI.BAT: success " Patchwork
2025-03-21 15:47 ` ✗ i915.CI.Full: failure " Patchwork
2025-03-30 14:43 ` [RESEND] drm/i915/gvt: use hardcoded reference clocks Zhenyu Wang
2025-04-01 8:58 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734es45si.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
--cc=zhenyuw.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox