Re: [PATCH 2/5] drm/i915/bios: Update VBT driver feature block version numbers

[Jani Nikula <jani.nikula@linux.intel.com>]

On Thu, 21 Mar 2024, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> While the spec does claim that most of the driver feature flags
> start from BDB version 165, reality and some VBIOS code disagrees.
> The VBIOS code says it sart from version 159, and my ILK
> with version 162 definitely has these things already in its
> VBT. Update the version number comments to say 159+ for all
> the bits that seem relevant for pre-hsw hardware.

I didn't bother digging though my old docs and references, but I'll take
your word for it.

Acked-by: Jani Nikula <jani.nikula@intel.com>


>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_vbt_defs.h | 20 +++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> index f2506b0be790..24583b455f2d 100644
> --- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> +++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> @@ -603,22 +603,22 @@ struct bdb_driver_features {
>  	u8 custom_vbt_version;					/* 155+ */
>  
>  	/* Driver Feature Flags */
> -	u16 rmpm_enabled:1;					/* 165+ */
> -	u16 s2ddt_enabled:1;					/* 165+ */
> -	u16 dpst_enabled:1;					/* 165-227 */
> -	u16 bltclt_enabled:1;					/* 165+ */
> -	u16 adb_enabled:1;					/* 165-227 */
> -	u16 drrs_enabled:1;					/* 165-227 */
> -	u16 grs_enabled:1;					/* 165+ */
> -	u16 gpmt_enabled:1;					/* 165+ */
> -	u16 tbt_enabled:1;					/* 165+ */
> +	u16 rmpm_enabled:1;					/* 159+ */
> +	u16 s2ddt_enabled:1;					/* 159+ */
> +	u16 dpst_enabled:1;					/* 159-227 */
> +	u16 bltclt_enabled:1;					/* 159+ */
> +	u16 adb_enabled:1;					/* 159-227 */
> +	u16 drrs_enabled:1;					/* 159-227 */
> +	u16 grs_enabled:1;					/* 159+ */
> +	u16 gpmt_enabled:1;					/* 159+ */
> +	u16 tbt_enabled:1;					/* 159+ */
>  	u16 psr_enabled:1;					/* 165-227 */
>  	u16 ips_enabled:1;					/* 165+ */
>  	u16 dfps_enabled:1;					/* 165+ */
>  	u16 dmrrs_enabled:1;					/* 174-227 */
>  	u16 adt_enabled:1;					/* ???-228 */
>  	u16 hpd_wake:1;						/* 201-240 */
> -	u16 pc_feature_valid:1;
> +	u16 pc_feature_valid:1;					/* 159+ */
>  } __packed;
>  
>  /*

-- 
Jani Nikula, Intel