From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: David Airlie <airlied@linux.ie>,
kernel-janitors@vger.kernel.org, intel-gfx@lists.freedesktop.org,
Chris Wilson <chris@chris-wilson.co.uk>,
Matthew Auld <matthew.auld@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Fix an error code i915_gem_object_copy_blt()
Date: Thu, 10 Sep 2020 23:14:19 +0300 [thread overview]
Message-ID: <87363p4cf8.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20200910100850.GD79916@mwanda>
Dan Carpenter <dan.carpenter@oracle.com> writes:
> This code should use "vma[1]" instead of "vma". The "vma" is a variable
> is a valid pointer.
Not quite getting the last sentence with my non native english parser.
"vma" is array would make sense.
>
> Fixes: 6b05030496f7 ("drm/i915: Convert i915_gem_object/client_blt.c to use ww locking as well, v2.")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_object_blt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object_blt.c b/drivers/gpu/drm/i915/gem/i915_gem_object_blt.c
> index d93eb36160c9..aee7ad3cc3c6 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_object_blt.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_object_blt.c
> @@ -364,7 +364,7 @@ int i915_gem_object_copy_blt(struct drm_i915_gem_object *src,
>
> vma[1] = i915_vma_instance(dst, vm, NULL);
> if (IS_ERR(vma[1]))
> - return PTR_ERR(vma);
> + return PTR_ERR(vma[1]);
>
> i915_gem_ww_ctx_init(&ww, true);
> intel_engine_pm_get(ce->engine);
> --
> 2.28.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-09-10 20:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 10:08 [Intel-gfx] [PATCH] drm/i915: Fix an error code i915_gem_object_copy_blt() Dan Carpenter
2020-09-10 12:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-09-10 13:23 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-09-10 20:14 ` Mika Kuoppala [this message]
2020-09-11 7:52 ` [Intel-gfx] [PATCH v2] " Dan Carpenter
2020-09-17 10:49 ` Maarten Lankhorst
2020-09-11 9:02 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix an error code i915_gem_object_copy_blt() (rev2) Patchwork
2020-09-11 10:48 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87363p4cf8.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=airlied@linux.ie \
--cc=chris@chris-wilson.co.uk \
--cc=dan.carpenter@oracle.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox