From: Eric Anholt <eric@anholt.net>
To: dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org,
"Noralf Trønnes" <noralf@tronnes.org>,
sam@ravnborg.org, david@lechnology.com, christian.koenig@amd.com
Subject: Re: [PATCH 4/5] drm/cma-helper: Add DRM_GEM_CMA_VMAP_DRIVER_OPS
Date: Fri, 16 Nov 2018 13:35:17 -0800 [thread overview]
Message-ID: <8736s0d7u2.fsf@anholt.net> (raw)
In-Reply-To: <20181110145647.17580-5-noralf@tronnes.org>
[-- Attachment #1.1: Type: text/plain, Size: 548 bytes --]
Noralf Trønnes <noralf@tronnes.org> writes:
> This adds functionality to the CMA helper which ensures that the kernel
> virtual address is set on the CMA GEM object also for imported buffers.
>
> The drivers have been audited to ensure that none set ->vaddr on imported
> buffers, making the conditional dma_buf_vunmap() call in
> drm_gem_cma_free_object() safe.
>
> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
I didn't look through 1-3 much since they had acks, but 4/5 get my:
Reviewed-by: Eric Anholt <eric@anholt.net>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-11-16 21:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-10 14:56 [PATCH 0/5] drm/gem: Add drm_gem_object_funcs Noralf Trønnes
2018-11-10 14:56 ` [PATCH 1/5] drm/driver: Add defaults for .gem_prime_export/import callbacks Noralf Trønnes
2018-11-10 14:56 ` [PATCH 2/5] drm/prime: Add drm_gem_prime_mmap() Noralf Trønnes
2018-11-10 14:56 ` [PATCH 3/5] drm/gem: Add drm_gem_object_funcs Noralf Trønnes
2018-11-10 14:56 ` [PATCH 4/5] drm/cma-helper: Add DRM_GEM_CMA_VMAP_DRIVER_OPS Noralf Trønnes
2018-11-16 21:35 ` Eric Anholt [this message]
2018-11-10 14:56 ` [PATCH 5/5] drm/tinydrm: Use DRM_GEM_CMA_VMAP_DRIVER_OPS Noralf Trønnes
2018-11-10 15:27 ` ✓ Fi.CI.BAT: success for drm/gem: Add drm_gem_object_funcs Patchwork
2018-11-10 16:39 ` ✓ Fi.CI.IGT: " Patchwork
2018-11-12 10:07 ` [PATCH 0/5] " Koenig, Christian
2018-11-20 14:15 ` Noralf Trønnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736s0d7u2.fsf@anholt.net \
--to=eric@anholt.net \
--cc=christian.koenig@amd.com \
--cc=david@lechnology.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=noralf@tronnes.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox