From: Jani Nikula <jani.nikula@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Raag Jadav <raag.jadav@intel.com>
Cc: airlied@gmail.com, simona@ffwll.ch, lucas.demarchi@intel.com,
thomas.hellstrom@linux.intel.com, rodrigo.vivi@intel.com,
joonas.lahtinen@linux.intel.com, tursulin@ursulin.net,
lina@asahilina.net, intel-xe@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
himal.prasad.ghimiray@intel.com, francois.dugast@intel.com,
aravind.iddamsetty@linux.intel.com, anshuman.gupta@intel.com,
andi.shyti@linux.intel.com, matthew.d.roper@intel.com
Subject: Re: [PATCH v6 1/4] drm: Introduce device wedged event
Date: Tue, 24 Sep 2024 01:01:48 +0300 [thread overview]
Message-ID: <874j6658s3.fsf@intel.com> (raw)
In-Reply-To: <ZvGB9P_JdXcnTfW2@smile.fi.intel.com>
On Mon, 23 Sep 2024, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> On Mon, Sep 23, 2024 at 05:35:23PM +0300, Raag Jadav wrote:
>> On Mon, Sep 23, 2024 at 11:38:55AM +0300, Andy Shevchenko wrote:
>> > On Mon, Sep 23, 2024 at 09:28:23AM +0530, Raag Jadav wrote:
>
> ...
>
>> > > +extern const char *const wedge_recovery_opts[];
>> >
>> > It's not NULL terminated. How users will know that they have an index valid?
>>
>> It's expected to be accessed using recovery_*() helpers.
>
> If so, this has to be static then.
Yeah, please make the helpers regular functions. Static inlines are just
harmful here.
BR,
Jani.
>
>> > Either you NULL-terminate that, or export the size as well (personally I would
>> > go with the first approach).
--
Jani Nikula, Intel
next prev parent reply other threads:[~2024-09-23 22:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-23 3:58 [PATCH v6 0/4] Introduce DRM device wedged event Raag Jadav
2024-09-23 3:58 ` [PATCH v6 1/4] drm: Introduce " Raag Jadav
2024-09-23 8:38 ` Andy Shevchenko
2024-09-23 14:35 ` Raag Jadav
2024-09-23 14:57 ` Andy Shevchenko
2024-09-23 22:01 ` Jani Nikula [this message]
2024-09-24 11:23 ` Simona Vetter
2024-09-25 3:04 ` Raag Jadav
2024-09-25 11:53 ` Simona Vetter
2024-09-23 3:58 ` [PATCH v6 2/4] drm: Expose wedge recovery methods Raag Jadav
2024-09-23 3:58 ` [PATCH v6 3/4] drm/xe: Use device wedged event Raag Jadav
2024-09-23 3:58 ` [PATCH v6 4/4] drm/i915: " Raag Jadav
2024-09-25 15:34 ` ✗ Fi.CI.CHECKPATCH: warning for Introduce DRM device wedged event (rev4) Patchwork
2024-09-25 15:34 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-09-25 16:11 ` ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874j6658s3.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@gmail.com \
--cc=andi.shyti@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=anshuman.gupta@intel.com \
--cc=aravind.iddamsetty@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=francois.dugast@intel.com \
--cc=himal.prasad.ghimiray@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=lina@asahilina.net \
--cc=lucas.demarchi@intel.com \
--cc=matthew.d.roper@intel.com \
--cc=raag.jadav@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=thomas.hellstrom@linux.intel.com \
--cc=tursulin@ursulin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox