Re: [Intel-gfx] [PATCH 2/5] drm/i915: utilize subconnector property for DP

[Jani Nikula <jani.nikula@intel.com>]

On Tue, 07 Apr 2020, Jeevan B <jeevan.b@intel.com> wrote:
> From: Oleg Vasilev <oleg.vasilev@intel.com>
>
> Since DP-specific information is stored in driver's structures, every
> driver needs to implement subconnector property by itself.
>
> v2: updates to match previous commit changes
>
> v3: rebase
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Signed-off-by: Jeevan B <jeevan.b@intel.com>
> Signed-off-by: Oleg Vasilev <oleg.vasilev@intel.com>
> Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
> Tested-by: Oleg Vasilev <oleg.vasilev@intel.com>
> Link: https://patchwork.freedesktop.org/patch/msgid/20190829114854.1539-4-oleg.vasilev@intel.com

You're not supposed to add the Link: tag yourself.

Reviewed-by: Jani Nikula <jani.nikula@intel.com>


> ---
>  drivers/gpu/drm/i915/display/intel_dp.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index db6ae8e..ba443e1 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -6155,6 +6155,11 @@ intel_dp_detect(struct drm_connector *connector,
>  	 */
>  	intel_display_power_flush_work(dev_priv);
>  
> +	if (!intel_dp_is_edp(intel_dp))
> +		drm_dp_set_subconnector_property(connector,
> +						 status,
> +						 intel_dp->dpcd,
> +						 intel_dp->downstream_ports);
>  	return status;
>  }
>  
> @@ -7211,6 +7216,9 @@ intel_dp_add_properties(struct intel_dp *intel_dp, struct drm_connector *connect
>  	struct drm_i915_private *dev_priv = to_i915(connector->dev);
>  	enum port port = dp_to_dig_port(intel_dp)->base.port;
>  
> +	if (!intel_dp_is_edp(intel_dp))
> +		drm_mode_add_dp_subconnector_property(connector);
> +
>  	if (!IS_G4X(dev_priv) && port != PORT_A)
>  		intel_attach_force_audio_property(connector);

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx