From: Jani Nikula <jani.nikula@intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/debugfs: remove VBT data about DRRS
Date: Fri, 31 Jan 2020 10:58:44 +0200 [thread overview]
Message-ID: <874kwc9f3v.fsf@intel.com> (raw)
In-Reply-To: <20200128155114.GK13686@intel.com>
On Tue, 28 Jan 2020, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Tue, Jan 28, 2020 at 05:19:42PM +0200, Jani Nikula wrote:
>> The debugfs is not the place to print duplicated info about VBT data.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>> drivers/gpu/drm/i915/i915_debugfs.c | 11 +----------
>> 1 file changed, 1 insertion(+), 10 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
>> index 8992698510ee..7f4976c10cea 100644
>> --- a/drivers/gpu/drm/i915/i915_debugfs.c
>> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
>> @@ -2921,16 +2921,7 @@ static void drrs_status_per_crtc(struct seq_file *m,
>> }
>> drm_connector_list_iter_end(&conn_iter);
>>
>> - if (dev_priv->vbt.drrs_type == STATIC_DRRS_SUPPORT)
>> - seq_puts(m, "\tVBT: DRRS_type: Static");
>> - else if (dev_priv->vbt.drrs_type == SEAMLESS_DRRS_SUPPORT)
>> - seq_puts(m, "\tVBT: DRRS_type: Seamless");
>> - else if (dev_priv->vbt.drrs_type == DRRS_NOT_SUPPORTED)
>> - seq_puts(m, "\tVBT: DRRS_type: None");
>> - else
>> - seq_puts(m, "\tVBT: DRRS_type: FIXME: Unrecognized Value");
>> -
>> - seq_puts(m, "\n\n");
>> + seq_puts(m, "\n");
>
> Less stuff to worry about for my fix drrs branch.
\o/
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Thanks for the review, pushed to dinq.
BR,
Jani.
>
>>
>> if (to_intel_crtc_state(intel_crtc->base.state)->has_drrs) {
>> struct intel_panel *panel;
>> --
>> 2.20.1
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-01-31 8:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-28 15:19 [Intel-gfx] [PATCH] drm/i915/debugfs: remove VBT data about DRRS Jani Nikula
2020-01-28 15:51 ` Ville Syrjälä
2020-01-31 8:58 ` Jani Nikula [this message]
2020-01-28 23:10 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-01-30 15:59 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kwc9f3v.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox