Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/i915: Drop debugfs/i915_next_seqno
Date: Fri, 28 Dec 2018 15:04:09 +0200	[thread overview]
Message-ID: <874lax6bw6.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20181228123626.1465-3-chris@chris-wilson.co.uk>

Chris Wilson <chris@chris-wilson.co.uk> writes:

> Having just gutted the implementation as there is no global seqno
> tracking, remove the vestigal write-only stub for debugfs/i915_next_seqno.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>

Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/i915_debugfs.c | 11 -----------
>  1 file changed, 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 1269d734ade0..b89abbba4604 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -1038,16 +1038,6 @@ static const struct file_operations i915_error_state_fops = {
>  };
>  #endif
>  
> -static int
> -i915_next_seqno_set(void *data, u64 val)
> -{
> -	return val ? 0 : -EINVAL;
> -}
> -
> -DEFINE_SIMPLE_ATTRIBUTE(i915_next_seqno_fops,
> -			NULL, i915_next_seqno_set,
> -			"0x%llx\n");
> -
>  static int i915_frequency_info(struct seq_file *m, void *unused)
>  {
>  	struct drm_i915_private *dev_priv = node_to_i915(m->private);
> @@ -4811,7 +4801,6 @@ static const struct i915_debugfs_files {
>  	{"i915_gpu_info", &i915_gpu_info_fops},
>  #endif
>  	{"i915_fifo_underrun_reset", &i915_fifo_underrun_reset_ops},
> -	{"i915_next_seqno", &i915_next_seqno_fops},
>  	{"i915_pri_wm_latency", &i915_pri_wm_latency_fops},
>  	{"i915_spr_wm_latency", &i915_spr_wm_latency_fops},
>  	{"i915_cur_wm_latency", &i915_cur_wm_latency_fops},
> -- 
> 2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-12-28 13:05 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-28 12:36 [PATCH 1/3] drm/i915: Implement Selective Write workaround for Haswell GT1 Chris Wilson
2018-12-28 12:36 ` [PATCH 2/3] drm/i915: Remove HW semaphores for gen7 inter-engine synchronisation Chris Wilson
2018-12-28 12:36 ` [PATCH 3/3] drm/i915: Drop debugfs/i915_next_seqno Chris Wilson
2018-12-28 13:04   ` Mika Kuoppala [this message]
2018-12-28 12:52 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915: Implement Selective Write workaround for Haswell GT1 Patchwork
2018-12-28 12:54 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-12-28 13:03 ` [PATCH 1/3] " Mika Kuoppala
2018-12-28 13:17 ` ✗ Fi.CI.BAT: failure for series starting with [1/3] " Patchwork
2018-12-28 13:21   ` Chris Wilson
2018-12-28 13:48     ` Mika Kuoppala
2018-12-28 13:55       ` Chris Wilson
2018-12-28 13:42 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915: Implement Selective Write workaround for Haswell GT1 (rev2) Patchwork
2018-12-28 13:43 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-12-28 14:01 ` ✗ Fi.CI.BAT: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2018-12-28 14:07 [PATCH 1/3] drm/i915: Restrict PSMI context load w/a to Haswell GT1 Chris Wilson
2018-12-28 14:07 ` [PATCH 3/3] drm/i915: Drop debugfs/i915_next_seqno Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874lax6bw6.fsf@gaia.fi.intel.com \
    --to=mika.kuoppala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox