From: Jani Nikula <jani.nikula@intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: make plane func structs const
Date: Wed, 13 Jun 2018 15:30:59 +0300 [thread overview]
Message-ID: <874li627i4.fsf@intel.com> (raw)
In-Reply-To: <20180613122425.GJ23723@intel.com>
On Wed, 13 Jun 2018, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Wed, Jun 13, 2018 at 01:24:22PM +0300, Jani Nikula wrote:
>> No reason not to be const.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> https://patchwork.freedesktop.org/patch/226875/
Okay, rb on that.
BR,
Jani.
>
>> ---
>> drivers/gpu/drm/i915/intel_display.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
>> index 2c16c3a3cdea..4bb8c12c333f 100644
>> --- a/drivers/gpu/drm/i915/intel_display.c
>> +++ b/drivers/gpu/drm/i915/intel_display.c
>> @@ -13346,7 +13346,7 @@ static bool intel_cursor_format_mod_supported(struct drm_plane *_plane,
>> format == DRM_FORMAT_ARGB8888;
>> }
>>
>> -static struct drm_plane_funcs skl_plane_funcs = {
>> +static const struct drm_plane_funcs skl_plane_funcs = {
>> .update_plane = drm_atomic_helper_update_plane,
>> .disable_plane = drm_atomic_helper_disable_plane,
>> .destroy = intel_plane_destroy,
>> @@ -13357,7 +13357,7 @@ static struct drm_plane_funcs skl_plane_funcs = {
>> .format_mod_supported = skl_plane_format_mod_supported,
>> };
>>
>> -static struct drm_plane_funcs i965_plane_funcs = {
>> +static const struct drm_plane_funcs i965_plane_funcs = {
>> .update_plane = drm_atomic_helper_update_plane,
>> .disable_plane = drm_atomic_helper_disable_plane,
>> .destroy = intel_plane_destroy,
>> @@ -13368,7 +13368,7 @@ static struct drm_plane_funcs i965_plane_funcs = {
>> .format_mod_supported = i965_plane_format_mod_supported,
>> };
>>
>> -static struct drm_plane_funcs i8xx_plane_funcs = {
>> +static const struct drm_plane_funcs i8xx_plane_funcs = {
>> .update_plane = drm_atomic_helper_update_plane,
>> .disable_plane = drm_atomic_helper_disable_plane,
>> .destroy = intel_plane_destroy,
>> --
>> 2.11.0
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2018-06-13 12:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 10:24 [PATCH] drm/i915: make plane func structs const Jani Nikula
2018-06-13 10:48 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-06-13 12:07 ` ✓ Fi.CI.IGT: " Patchwork
2018-06-13 12:24 ` [PATCH] " Ville Syrjälä
2018-06-13 12:30 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874li627i4.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox