From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [Intel-gfx] [Intel-xe] [PATCH v3 1/6] drm/i915: Initialize dkl_phy spin lock from display code path
Date: Tue, 11 Apr 2023 12:14:36 +0300 [thread overview]
Message-ID: <875ya2eq6b.fsf@intel.com> (raw)
In-Reply-To: <ZDUkZKotRVT0bxga@intel.com>
On Tue, 11 Apr 2023, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Tue, Apr 11, 2023 at 11:51:33AM +0300, Jani Nikula wrote:
>> On Tue, 11 Apr 2023, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
>> > On Mon, Apr 10, 2023 at 11:32:14AM -0700, José Roberto de Souza wrote:
>> >> Start to move the initialization of some lock from
>> >> i915_driver_early_probe().
>> >> No dkl function is called prior to intel_setup_outputs(), so this is
>> >> a good place to initialize it.
>> >
>> > I disagree. We don't want to sprinke these all over the place.
>>
>> I'm thinking if only foo.c uses a lock, foo.c should initialize it, not
>> someone else.
>
> Perhaps. But I think there should be some consistent place in the higher
> level code where all such things get called instead of dropping each one
> individually into some random spot in the overlall display init flow.
Agreed.
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2023-04-11 9:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-10 18:32 [Intel-gfx] [PATCH v3 1/6] drm/i915: Initialize dkl_phy spin lock from display code path José Roberto de Souza
2023-04-10 18:32 ` [Intel-gfx] [PATCH v3 2/6] drm/i915: Only initialize dlk phy lock in display 12 and newer José Roberto de Souza
2023-04-11 8:38 ` Ville Syrjälä
2023-04-11 8:32 ` [Intel-gfx] [Intel-xe] [PATCH v3 1/6] drm/i915: Initialize dkl_phy spin lock from display code path Jani Nikula
2023-04-11 8:33 ` Jani Nikula
2023-04-11 13:24 ` Souza, Jose
2023-04-11 8:39 ` [Intel-gfx] " Ville Syrjälä
2023-04-11 8:51 ` [Intel-gfx] [Intel-xe] " Jani Nikula
2023-04-11 9:12 ` Ville Syrjälä
2023-04-11 9:14 ` Jani Nikula [this message]
2023-04-11 14:51 ` Rodrigo Vivi
2023-04-11 19:59 ` Lucas De Marchi
2023-04-11 20:07 ` Souza, Jose
2023-04-11 21:20 ` Lucas De Marchi
2023-04-12 17:13 ` Souza, Jose
2023-04-13 8:22 ` Jani Nikula
2023-04-13 9:49 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875ya2eq6b.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox