From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915/oa: add content to Makefile
Date: Tue, 30 Jul 2019 14:36:32 +0300 [thread overview]
Message-ID: <875znjoitb.fsf@intel.com> (raw)
In-Reply-To: <20190730102824.9434-1-jani.nikula@intel.com>
On Tue, 30 Jul 2019, Jani Nikula <jani.nikula@intel.com> wrote:
> Apparently the empty Makefile has caused some confusion. Add the
> subdir-cc-flags-y as in 7fcc7ca549d4 ("drm/i915: add header search path
> to subdir Makefiles") which should be useful.
>
> The generated headers still aren't self-contained, so can't add that.
>
> References: http://marc.info/?i=80bf2204-558a-6d3f-c493-bf17b891fc8a@infradead.org
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> ---
>
> This should fix the kernel header generation:
> https://github.com/rib/gputop/pull/203
Now that Lionel helpfully merged that, I updated the series with a patch
addressing the generated headers as well. New series at
https://patchwork.freedesktop.org/series/64427/
BR,
Jani.
> ---
> drivers/gpu/drm/i915/oa/Makefile | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/oa/Makefile b/drivers/gpu/drm/i915/oa/Makefile
> index e69de29bb2d1..256bfde4a287 100644
> --- a/drivers/gpu/drm/i915/oa/Makefile
> +++ b/drivers/gpu/drm/i915/oa/Makefile
> @@ -0,0 +1,4 @@
> +# SPDX-License-Identifier: MIT
> +
> +# For building individual subdir files on the command line
> +subdir-ccflags-y += -I$(srctree)/$(src)/..
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-07-30 11:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 10:28 [PATCH 1/2] drm/i915/oa: add content to Makefile Jani Nikula
2019-07-30 10:28 ` [PATCH 2/2] drm/i915: add SPDX headers to subdir Makefiles Jani Nikula
2019-07-30 11:36 ` Jani Nikula [this message]
2019-07-30 12:16 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/oa: add content to Makefile Patchwork
2019-07-30 12:36 ` ✓ Fi.CI.BAT: success " Patchwork
2019-07-30 21:54 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875znjoitb.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox