From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/8] drm/i915: Replace engine->timeline with a plain list
Date: Fri, 14 Jun 2019 19:18:59 +0300 [thread overview]
Message-ID: <875zp887ik.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <156052789225.7796.5111655254369629818@skylake-alporthouse-com>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> Quoting Mika Kuoppala (2019-06-14 16:50:33)
>> Chris Wilson <chris@chris-wilson.co.uk> writes:
>> > @@ -254,6 +254,7 @@ static bool i915_request_retire(struct i915_request *rq)
>> > intel_context_unpin(rq->hw_context);
>> >
>> > i915_request_remove_from_client(rq);
>> > + list_del(&rq->link);
>>
>> This is now unguarded. and the timeline mutex is not here
>> to help either.
>
> It is guarded by the caller to i915_request_retire, we can only retire
> under the same lock as we construct requests. Currently that is
> struct_mutex with the big switcheroo coming at the end.
Yup found it.
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> -Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-06-14 16:19 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 9:31 Endless busyness, the forecoming Chris Wilson
2019-06-12 9:31 ` [PATCH 1/8] drm/i915: Keep contexts pinned until after the next kernel context switch Chris Wilson
2019-06-12 13:29 ` Mika Kuoppala
2019-06-12 13:42 ` Chris Wilson
2019-06-12 14:09 ` Mika Kuoppala
2019-06-12 14:17 ` Chris Wilson
2019-06-12 14:26 ` [PATCH v2] " Chris Wilson
2019-06-14 9:22 ` Mika Kuoppala
2019-06-14 9:34 ` Chris Wilson
2019-06-14 10:18 ` Mika Kuoppala
2019-06-12 9:31 ` [PATCH 2/8] drm/i915: Stop retiring along engine Chris Wilson
2019-06-14 14:23 ` Mika Kuoppala
2019-06-12 9:31 ` [PATCH 3/8] drm/i915: Replace engine->timeline with a plain list Chris Wilson
2019-06-14 14:34 ` Mika Kuoppala
2019-06-14 14:44 ` Chris Wilson
2019-06-14 15:50 ` Mika Kuoppala
2019-06-14 15:58 ` Chris Wilson
2019-06-14 16:18 ` Mika Kuoppala [this message]
2019-06-12 9:31 ` [PATCH 4/8] drm/i915: Flush the execution-callbacks on retiring Chris Wilson
2019-06-12 9:31 ` [PATCH 5/8] drm/i915/execlists: Preempt-to-busy Chris Wilson
2019-06-12 9:31 ` [PATCH 6/8] drm/i915/execlists: Minimalistic timeslicing Chris Wilson
2019-06-12 9:31 ` [PATCH 7/8] drm/i915/execlists: Force preemption Chris Wilson
2019-06-12 9:31 ` [PATCH 8/8] drm/i915: Add a label for config DRM_I915_SPIN_REQUEST Chris Wilson
2019-06-12 9:53 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/8] drm/i915: Keep contexts pinned until after the next kernel context switch Patchwork
2019-06-12 9:57 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-06-12 10:16 ` ✓ Fi.CI.BAT: success " Patchwork
2019-06-12 15:29 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2] drm/i915: Keep contexts pinned until after the next kernel context switch (rev2) Patchwork
2019-06-12 15:33 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-06-12 16:00 ` ✓ Fi.CI.BAT: success " Patchwork
2019-06-13 6:16 ` ✗ Fi.CI.IGT: failure for series starting with [1/8] drm/i915: Keep contexts pinned until after the next kernel context switch Patchwork
2019-06-14 9:58 ` ✗ Fi.CI.IGT: failure for series starting with [v2] drm/i915: Keep contexts pinned until after the next kernel context switch (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zp887ik.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox