From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/icl: Remove Wa_1604302699
Date: Thu, 29 Nov 2018 15:56:03 +0200 [thread overview]
Message-ID: <875zwgf0ng.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20181129134630.8222-1-tvrtko.ursulin@linux.intel.com>
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> writes:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> It seems that the documentation does not reference this any more, plus,
> bit 28 does not stick when written to the register.
>
> Therefore I can only assume this is something which was documented in the
> past but got removed from the hardware in the meantime.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_workarounds.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_workarounds.c b/drivers/gpu/drm/i915/intel_workarounds.c
> index 39cd1f823ea9..e5cd6c6c66c3 100644
> --- a/drivers/gpu/drm/i915/intel_workarounds.c
> +++ b/drivers/gpu/drm/i915/intel_workarounds.c
> @@ -882,11 +882,6 @@ static void icl_gt_workarounds_apply(struct drm_i915_private *dev_priv)
> I915_READ(SUBSLICE_UNIT_LEVEL_CLKGATE) |
> GWUNIT_CLKGATE_DIS);
>
> - /* Wa_1604302699:icl */
> - I915_WRITE(GEN10_L3_CHICKEN_MODE_REGISTER,
> - I915_READ(GEN10_L3_CHICKEN_MODE_REGISTER) |
> - GEN11_I2M_WRITE_DISABLE);
> -
> /* Wa_1406838659:icl (pre-prod) */
> if (IS_ICL_REVID(dev_priv, ICL_REVID_A0, ICL_REVID_B0))
> I915_WRITE(INF_UNIT_LEVEL_CLKGATE,
> --
> 2.19.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-11-29 13:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 13:46 [PATCH] drm/i915/icl: Remove Wa_1604302699 Tvrtko Ursulin
2018-11-29 13:56 ` Mika Kuoppala [this message]
2018-11-29 14:47 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-11-30 15:10 ` Tvrtko Ursulin
2018-11-30 2:11 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zwgf0ng.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox