From: Jani Nikula <jani.nikula@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Move EDRAM capability bits to intel_driver_caps
Date: Fri, 09 Feb 2018 14:09:29 +0200 [thread overview]
Message-ID: <8760768iva.fsf@intel.com> (raw)
In-Reply-To: <151817591965.28809.1933706060104516096@mail.alporthouse.com>
On Fri, 09 Feb 2018, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Chris Wilson (2018-02-09 11:29:08)
>> Move the storage of the runtime discovery of EDRAM to intel_driver_caps
>> so that we include it in all the relevant error state dumping and
>> debugging.
>>
>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>> ---
>>
>> Or do we want to keep driver_caps only for driver related info, and move
>> this sort of runtime discovery to intel_runtime_info? With the intention
>> of killing off all remaining mkwrite_intel_info()
>
> I think I prefer a new intel_runtime_info, then we have
>
> static intel_device_info,
> write-once (hopefully!) intel_runtime_info,
> mutable intel_driver_caps
Yeah, I'd like to see mkwrite_intel_info() go.
I suppose struct drm_i915_private would then have a const pointer field
to device info? That's one painful change. I think better to go with
changing everything to use INTEL_INFO() (or intel_info()?) first. Auch.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-02-09 12:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-09 11:29 [PATCH] drm/i915: Move EDRAM capability bits to intel_driver_caps Chris Wilson
2018-02-09 11:31 ` Chris Wilson
2018-02-09 12:09 ` Jani Nikula [this message]
2018-02-09 15:12 ` ✗ Fi.CI.BAT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760768iva.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox