Re: [PATCH] drm/i915/psr: disable psr2 for resolution greater than 32X20

[Jani Nikula <jani.nikula@linux.intel.com>]

On Tue, 23 May 2017, "Vivi, Rodrigo" <rodrigo.vivi@intel.com> wrote:
> A bit of history on the commit message pointing the commit that
> introduced the issue is desired.

s/desired/absolutely required/.

BR,
Jani.


>
> With that in place feel free to use:
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> On Tue, 2017-05-23 at 22:27 +0530, vathsala nagaraju wrote:
>> psr1 is also disabled for panel resolution  greater than 32X20.
>> Added psr2 check to disable only for psr2 panels having resolution
>> greater than 32X20.
>> 
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Cc: Jim Bride <jim.bride@linux.intel.com>
>> Cc: Yaroslav Shabalin <yaroslav.shabalin@gmail.com>
>> Signed-off-by: vathsala nagaraju <vathsala.nagaraju@intel.com>
>> ---
>>  drivers/gpu/drm/i915/intel_psr.c | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c
>> index c3780d0..559f1ab 100644
>> --- a/drivers/gpu/drm/i915/intel_psr.c
>> +++ b/drivers/gpu/drm/i915/intel_psr.c
>> @@ -435,8 +435,9 @@ static bool intel_psr_match_conditions(struct intel_dp *intel_dp)
>>  	}
>>  
>>  	/* PSR2 is restricted to work with panel resolutions upto 3200x2000 */
>> -	if (intel_crtc->config->pipe_src_w > 3200 ||
>> -				intel_crtc->config->pipe_src_h > 2000) {
>> +	if (dev_priv->psr.psr2_support &&
>> +	    (intel_crtc->config->pipe_src_w > 3200 ||
>> +	     intel_crtc->config->pipe_src_h > 2000)) {
>>  		dev_priv->psr.psr2_support = false;
>>  		return false;
>>  	}
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx