From: Fernando Pacheco <fernando.pacheco@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [CI 2/2] HAX: force enable_guc=2
Date: Wed, 22 Jan 2020 16:35:52 -0800 [thread overview]
Message-ID: <876b8257-7ec8-e5d2-0bff-e17394d3561f@intel.com> (raw)
In-Reply-To: <157969752459.7477.17596563244499908955@skylake-alporthouse-com>
On 1/22/20 4:52 AM, Chris Wilson wrote:
> Quoting Fernando Pacheco (2020-01-22 00:18:22)
>> Signed-off-by: Fernando Pacheco <fernando.pacheco@intel.com>
>> ---
>> drivers/gpu/drm/i915/i915_params.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
>> index 947d0a38fa3c..4d17235c33bd 100644
>> --- a/drivers/gpu/drm/i915/i915_params.h
>> +++ b/drivers/gpu/drm/i915/i915_params.h
>> @@ -56,7 +56,7 @@ struct drm_printer;
>> param(int, disable_power_well, -1, 0400) \
>> param(int, enable_ips, 1, 0600) \
>> param(int, invert_brightness, 0, 0600) \
>> - param(int, enable_guc, 0, 0400) \
>> + param(int, enable_guc, 2, 0400) \
>> param(int, guc_log_level, -1, 0400) \
>> param(char *, guc_firmware_path, NULL, 0400) \
>> param(char *, huc_firmware_path, NULL, 0400) \
> intel_guc_reset_engine() is only used in guc submission mode. This tests
> nothing.
The mmio list is only important when GuC owns the engine reset (new interface).
Just want to see here that the mmio list is constructed and formatted correctly when
we hand the info off via the ADS.
The reset flow will be fully tested during the push to turn submission on and the
contents of the list can/will be tweaked as part of that validation.
Fernando
> -Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-01-23 0:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 0:18 [Intel-gfx] [CI 1/2] drm/i915/guc: Provide mmio list to be saved/restored on engine reset Fernando Pacheco
2020-01-22 0:18 ` [Intel-gfx] [CI 2/2] HAX: force enable_guc=2 Fernando Pacheco
2020-01-22 12:52 ` Chris Wilson
2020-01-23 0:35 ` Fernando Pacheco [this message]
2020-01-22 0:39 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] drm/i915/guc: Provide mmio list to be saved/restored on engine reset Patchwork
2020-01-22 1:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-01-23 9:35 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=876b8257-7ec8-e5d2-0bff-e17394d3561f@intel.com \
--to=fernando.pacheco@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox