Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/4] drm/i915: Drop pointless (void*) cast
Date: Fri, 08 Mar 2024 11:46:47 +0200	[thread overview]
Message-ID: <877cidukc8.fsf@intel.com> (raw)
In-Reply-To: <20240307151810.24208-5-ville.syrjala@linux.intel.com>

On Thu, 07 Mar 2024, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Remove the pointless (void*) cast, the incoming pointer is already
> the correct type.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_sdvo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm/i915/display/intel_sdvo.c
> index 2b00ca44c14c..50f0557d9ca2 100644
> --- a/drivers/gpu/drm/i915/display/intel_sdvo.c
> +++ b/drivers/gpu/drm/i915/display/intel_sdvo.c
> @@ -2378,7 +2378,7 @@ intel_sdvo_connector_atomic_get_property(struct drm_connector *connector,
>  					 u64 *val)
>  {
>  	struct intel_sdvo_connector *intel_sdvo_connector = to_intel_sdvo_connector(connector);
> -	const struct intel_sdvo_connector_state *sdvo_state = to_intel_sdvo_connector_state((void *)state);
> +	const struct intel_sdvo_connector_state *sdvo_state = to_intel_sdvo_connector_state(state);
>  
>  	if (property == intel_sdvo_connector->tv_format) {
>  		int i;

-- 
Jani Nikula, Intel

  reply	other threads:[~2024-03-08  9:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-07 15:18 [PATCH 0/4] drm/i915: Use container_of_const() Ville Syrjala
2024-03-07 15:18 ` [PATCH 1/4] drm/i915/dsi: Use enc_to_intel_dsi() Ville Syrjala
2024-03-08  9:37   ` Jani Nikula
2024-03-07 15:18 ` [PATCH 2/4] drm/i915: Don't cast away const Ville Syrjala
2024-03-08  9:39   ` Jani Nikula
2024-03-07 15:18 ` [PATCH 3/4] drm/i915: Use container_of_const() for states Ville Syrjala
2024-03-08  9:46   ` Jani Nikula
2024-03-07 15:18 ` [PATCH 4/4] drm/i915: Drop pointless (void*) cast Ville Syrjala
2024-03-08  9:46   ` Jani Nikula [this message]
2024-03-07 22:10 ` ✗ Fi.CI.SPARSE: warning for drm/i915: Use container_of_const() Patchwork
2024-03-07 22:28 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-03-14  0:02 ` ✗ Fi.CI.SPARSE: warning for drm/i915: Use container_of_const() (rev2) Patchwork
2024-03-14  0:22 ` ✓ Fi.CI.BAT: success " Patchwork
2024-03-14  8:53 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877cidukc8.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox