From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/pmu: Fix wakeref leak in PMU busyness during reset
Date: Mon, 06 Dec 2021 18:08:17 -0800 [thread overview]
Message-ID: <877dch181a.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20211207020239.43402-1-umesh.nerlige.ramappa@intel.com>
On Mon, 06 Dec 2021 18:02:39 -0800, Umesh Nerlige Ramappa wrote:
>
> GuC PMU busyness gets gt wakeref if awake, but fails to release the
> wakeref if a reset is in progress. Release the wakeref if it was
> acquried successfully.
>
> v2: Simplify the fix (Ashutosh)
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
> ---
> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
> index 1f9d4fde421f..97311119da6f 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
> @@ -1206,7 +1206,7 @@ static ktime_t guc_engine_busyness(struct intel_engine_cs *engine, ktime_t *now)
> * start_gt_clk is derived from GuC state. To get a consistent
> * view of activity, we query the GuC state only if gt is awake.
> */
> - if (intel_gt_pm_get_if_awake(gt) && !in_reset) {
> + if (!in_reset && intel_gt_pm_get_if_awake(gt)) {
> stats_saved = *stats;
> gt_stamp_saved = guc->timestamp.gt_stamp;
> guc_update_engine_gt_clks(engine);
> --
> 2.20.1
>
next prev parent reply other threads:[~2021-12-07 2:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 2:02 [Intel-gfx] [PATCH] drm/i915/pmu: Fix wakeref leak in PMU busyness during reset Umesh Nerlige Ramappa
2021-12-07 2:08 ` Dixit, Ashutosh [this message]
2021-12-07 2:51 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pmu: Fix wakeref leak in PMU busyness during reset (rev2) Patchwork
2021-12-07 5:22 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-12-07 21:37 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pmu: Fix wakeref leak in PMU busyness during reset (rev3) Patchwork
2021-12-08 5:41 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-12-08 17:55 ` Patchwork
2021-12-08 18:38 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2021-12-07 0:45 [Intel-gfx] [PATCH] drm/i915/pmu: Fix wakeref leak in PMU busyness during reset Umesh Nerlige Ramappa
2021-12-07 1:30 ` Dixit, Ashutosh
2021-12-07 2:04 ` Umesh Nerlige Ramappa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dch181a.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=umesh.nerlige.ramappa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox