From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Souza, Jose" <jose.souza@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Stop using crtc->index as the pipe
Date: Tue, 27 Apr 2021 10:51:38 +0300 [thread overview]
Message-ID: <877dko5fn9.fsf@intel.com> (raw)
In-Reply-To: <YIdxhuyJ2cqxA+DX@intel.com>
On Tue, 27 Apr 2021, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Tue, Apr 27, 2021 at 12:07:21AM +0000, Souza, Jose wrote:
>> On Mon, 2021-04-26 at 21:56 +0300, Ville Syrjala wrote:
>> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> >
>> > The pipe crc code slipped theough the net when we tried to
>> > eliminate all crtc->index==pipe abuses. Remedy that.
>> >
>> > And while at it get rid of those nasty intel_crtc+drm_crtc
>> > pointer aliases.
>>
>> intel_crtc is broadly used,
>
> Not anymore. We've cleaned up almost all of it. Looks like only ~40 left
> vs. ~600 the other name. Probably a good time to clean up the rest
> finally.
Ack.
>
>> also we have the same for other structs like intel_connector, in my option that is better than _crtc x crtc.
>
> The _crtc is explicitly ugly to make sure people leave it well
> alone. Otherwise we can never get rid of these horrible aliasing
> pointers. It should only make an appearance in core/helper vfuncs
> and such. At some point I was even pondering some kind of macro
> magic to create semi-automatic wrappers so that we could always
> just use the intel_ types in our vfunc implementations.
>
> intel_crtc we've cleaned up the most I think, intel_encoder a bit less
> perhaps, and intel_connector not really at all. Hence you see a lot more
> of intel_connector floating around. We also don't usually use the intel_
> types for connector states. Mainly because most of the time you don't
> need anyting from there.
Ack.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-04-27 7:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-26 18:56 [Intel-gfx] [PATCH] drm/i915: Stop using crtc->index as the pipe Ville Syrjala
2021-04-26 23:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-04-27 0:07 ` [Intel-gfx] [PATCH] " Souza, Jose
2021-04-27 2:05 ` Ville Syrjälä
2021-04-27 7:51 ` Jani Nikula [this message]
2021-04-27 16:09 ` Souza, Jose
2021-04-27 9:56 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
2021-04-27 10:33 ` [Intel-gfx] [PATCH] " Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dko5fn9.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jose.souza@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox