From: Jani Nikula <jani.nikula@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Add DEBUG_GEM to the recommended CI config
Date: Fri, 22 Jan 2021 10:58:24 +0200 [thread overview]
Message-ID: <877do5l55b.fsf@intel.com> (raw)
In-Reply-To: <20210114111817.3849-1-chris@chris-wilson.co.uk>
On Thu, 14 Jan 2021, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Now that i915 compiles cleanly with Werror, we can enforce enabling
> DEBUG_GEM when selecting the default debug config.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/Kconfig.debug | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug
> index 0fb7fd0ef717..3701bae5b855 100644
> --- a/drivers/gpu/drm/i915/Kconfig.debug
> +++ b/drivers/gpu/drm/i915/Kconfig.debug
> @@ -39,10 +39,12 @@ config DRM_I915_DEBUG
> select DRM_DEBUG_SELFTEST
> select DMABUF_SELFTESTS
> select SW_SYNC # signaling validation framework (igt/syncobj*)
> + select DRM_I915_WERROR
I think this line should be removed to fix [1]. Keep DRM_I915_WERROR
orthogonal.
BR,
Jani.
[1] http://lore.kernel.org/r/20210122115918.63b56fa1@canb.auug.org.au
> + select DRM_I915_DEBUG_GEM
> + select DRM_I915_DEBUG_MMIO
> + select DRM_I915_DEBUG_RUNTIME_PM
> select DRM_I915_SW_FENCE_DEBUG_OBJECTS
> select DRM_I915_SELFTEST
> - select DRM_I915_DEBUG_RUNTIME_PM
> - select DRM_I915_DEBUG_MMIO
> select BROKEN # for prototype uAPI
> default n
> help
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2021-01-22 8:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 11:18 [Intel-gfx] [PATCH] drm/i915: Add DEBUG_GEM to the recommended CI config Chris Wilson
2021-01-14 15:51 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-01-14 22:49 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-01-22 8:58 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877do5l55b.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox