From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [Intel-gfx] [PATCH 2/9] drm/i915/selftests: Use friendly request names for live_timeslice_rewind
Date: Tue, 16 Jun 2020 11:56:58 +0300 [thread overview]
Message-ID: <877dw7s811.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20200616084141.3722-2-chris@chris-wilson.co.uk>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> Rather than mixing [012] and (A1, A2, B2) for the request indices, use
> the enums throughout.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Yes, much more friendlier.
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/gt/selftest_lrc.c | 15 ++++++++-------
> 1 file changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c
> index 3d088116a055..72d52c9c042f 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_lrc.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c
> @@ -1176,18 +1176,18 @@ static int live_timeslice_rewind(void *arg)
> goto err;
> }
>
> - rq[0] = create_rewinder(ce, NULL, slot, X);
> - if (IS_ERR(rq[0])) {
> + rq[A1] = create_rewinder(ce, NULL, slot, X);
> + if (IS_ERR(rq[A1])) {
> intel_context_put(ce);
> goto err;
> }
>
> - rq[1] = create_rewinder(ce, NULL, slot, Y);
> + rq[A2] = create_rewinder(ce, NULL, slot, Y);
> intel_context_put(ce);
> - if (IS_ERR(rq[1]))
> + if (IS_ERR(rq[A2]))
> goto err;
>
> - err = wait_for_submit(engine, rq[1], HZ / 2);
> + err = wait_for_submit(engine, rq[A2], HZ / 2);
> if (err) {
> pr_err("%s: failed to submit first context\n",
> engine->name);
> @@ -1200,12 +1200,12 @@ static int live_timeslice_rewind(void *arg)
> goto err;
> }
>
> - rq[2] = create_rewinder(ce, rq[0], slot, Z);
> + rq[B1] = create_rewinder(ce, rq[A1], slot, Z);
> intel_context_put(ce);
> if (IS_ERR(rq[2]))
> goto err;
>
> - err = wait_for_submit(engine, rq[2], HZ / 2);
> + err = wait_for_submit(engine, rq[B1], HZ / 2);
> if (err) {
> pr_err("%s: failed to submit second context\n",
> engine->name);
> @@ -1213,6 +1213,7 @@ static int live_timeslice_rewind(void *arg)
> }
>
> /* ELSP[] = { { A:rq1, A:rq2 }, { B:rq1 } } */
> + ENGINE_TRACE(engine, "forcing tasklet for rewind\n");
> if (i915_request_is_active(rq[A2])) { /* semaphore yielded! */
> /* Wait for the timeslice to kick in */
> del_timer(&engine->execlists.timer);
> --
> 2.20.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-06-16 8:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 8:41 [Intel-gfx] [PATCH 1/9] drm/i915/selftests: Exercise far preemption rollbacks Chris Wilson
2020-06-16 8:41 ` [Intel-gfx] [PATCH 2/9] drm/i915/selftests: Use friendly request names for live_timeslice_rewind Chris Wilson
2020-06-16 8:56 ` Mika Kuoppala [this message]
2020-06-16 8:41 ` [Intel-gfx] [PATCH 3/9] drm/i915/selftests: Enable selftesting of busy-stats Chris Wilson
2020-06-16 9:03 ` Mika Kuoppala
2020-06-16 10:38 ` Chris Wilson
2020-06-16 8:41 ` [Intel-gfx] [PATCH 4/9] drm/i915/execlists: Replace direct submit with direct call to tasklet Chris Wilson
2020-06-16 9:35 ` Mika Kuoppala
2020-06-16 8:41 ` [Intel-gfx] [PATCH 5/9] drm/i915/execlists: Defer schedule_out until after the next dequeue Chris Wilson
2020-06-16 8:41 ` [Intel-gfx] [PATCH 6/9] drm/i915/gt: ce->inflight updates are now serialised Chris Wilson
2020-06-16 8:41 ` [Intel-gfx] [PATCH 7/9] drm/i915/gt: Drop atomic for engine->fw_active tracking Chris Wilson
2020-06-16 8:41 ` [Intel-gfx] [PATCH 8/9] drm/i915/gt: Extract busy-stats for ring-scheduler Chris Wilson
2020-06-16 8:41 ` [Intel-gfx] [PATCH 9/9] drm/i915/gt: Convert stats.active to plain unsigned int Chris Wilson
2020-06-16 8:55 ` [Intel-gfx] [PATCH 1/9] drm/i915/selftests: Exercise far preemption rollbacks Mika Kuoppala
2020-06-16 9:09 ` Chris Wilson
2020-06-16 9:45 ` Mika Kuoppala
2020-06-16 18:04 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/9] " Patchwork
2020-06-16 18:37 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dw7s811.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox