Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Anholt <eric@anholt.net>
To: DRI Development <dri-devel@lists.freedesktop.org>
Cc: linaro-mm-sig@lists.linaro.org,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	Sumit Semwal <sumit.semwal@linaro.org>,
	linux-media@vger.kernel.org
Subject: Re: [PATCH 01/17] dma-fence: Some kerneldoc polish for dma-fence.h
Date: Mon, 30 Apr 2018 10:49:00 -0700	[thread overview]
Message-ID: <877eoozisz.fsf@anholt.net> (raw)
In-Reply-To: <20180427061724.28497-2-daniel.vetter@ffwll.ch>


[-- Attachment #1.1: Type: text/plain, Size: 354 bytes --]

Daniel Vetter <daniel.vetter@ffwll.ch> writes:
> +	/**
> +	 * @fill_driver_data:
> +	 *
> +	 * Callback to fill in free-form debug info Returns amount of bytes
> +	 * filled, or negative error on failure.

Maybe this "Returns" should be on a new line?  Or at least a '.' in
between.

Other than that,

Reviewed-by: Eric Anholt <eric@anholt.net>

Thanks!

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-04-30 17:49 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-27  6:17 [PATCH 00/17] dma-fence doc polish and small cleanup Daniel Vetter
2018-04-27  6:17 ` [PATCH 01/17] dma-fence: Some kerneldoc polish for dma-fence.h Daniel Vetter
2018-04-30 17:49   ` Eric Anholt [this message]
2018-05-02  7:38     ` [Intel-gfx] " Daniel Vetter
2018-04-27  6:17 ` [PATCH 02/17] dma-fence: remove fill_driver_data callback Daniel Vetter
2018-04-30 17:49   ` Eric Anholt
2018-05-02  8:23   ` [PATCH] " Daniel Vetter
2018-05-02 16:57     ` Eric Anholt
2018-04-27  6:17 ` [PATCH 03/17] dma-fence: Make ->enable_signaling optional Daniel Vetter
2018-04-27  6:17 ` [PATCH 04/17] dma-fence: Allow wait_any_timeout for all fences Daniel Vetter
2018-04-29  7:11   ` Christian König
2018-04-30 15:35     ` Daniel Vetter
2018-04-27  6:17 ` [PATCH 05/17] dma-fence: Make ->wait callback optional Daniel Vetter
2018-04-27  6:17 ` [PATCH 06/17] drm/amdgpu: Remove unecessary dma_fence_ops Daniel Vetter
2018-04-29  7:12   ` Christian König
2018-04-27  6:17 ` [PATCH 07/17] drm: " Daniel Vetter
2018-04-30 17:51   ` Eric Anholt
2018-04-27  6:17 ` [PATCH 08/17] drm/etnaviv: " Daniel Vetter
2018-05-03 13:43   ` Lucas Stach
2018-04-27  6:17 ` [PATCH 09/17] drm/i915: " Daniel Vetter
     [not found] ` <20180427061724.28497-1-daniel.vetter-/w4YWyX8dFk@public.gmane.org>
2018-04-27  6:17   ` [PATCH 10/17] drm/msm: " Daniel Vetter
2018-04-27  6:17   ` [PATCH 11/17] drm/nouveau: " Daniel Vetter
2018-04-27  6:17 ` [PATCH 12/17] drm/qxl: " Daniel Vetter
2018-04-30 17:53   ` Eric Anholt
2018-05-02  8:23   ` [PATCH] " Daniel Vetter
2018-04-27  6:17 ` [PATCH 13/17] drm/radeon: Remove custom dma_fence_ops->wait implementation Daniel Vetter
2018-04-29  7:08   ` Christian König
2018-04-30 15:38     ` Daniel Vetter
     [not found]       ` <20180430153854.GR12521-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2018-04-30 18:26         ` Christian König
     [not found]           ` <ba53bdbd-3311-5836-4529-5374ccf6584a-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-04-30 19:35             ` Daniel Vetter
2018-04-27  6:17 ` [PATCH 14/17] drm/vc4: Remove unecessary dma_fence_ops Daniel Vetter
2018-04-30 17:50   ` Eric Anholt
2018-04-27  6:17 ` [PATCH 15/17] drm/vgem: " Daniel Vetter
2018-04-27  6:17 ` [PATCH 16/17] drm/virtio: " Daniel Vetter
2018-04-30 17:54   ` Eric Anholt
2018-04-27  6:17 ` [PATCH 17/17] dma-fence: Polish kernel-doc for dma-fence.c Daniel Vetter
2018-04-27  9:54 ` ✗ Fi.CI.CHECKPATCH: warning for dma-fence doc polish and small cleanup Patchwork
2018-04-27 10:06 ` ✗ Fi.CI.BAT: failure " Patchwork
2018-04-29  7:15 ` [PATCH 00/17] " Christian König
2018-05-02 12:19 ` ✗ Fi.CI.BAT: failure for dma-fence doc polish and small cleanup (rev3) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877eoozisz.fsf@anholt.net \
    --to=eric@anholt.net \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-media@vger.kernel.org \
    --cc=sumit.semwal@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox