RE: [PATCH] drm/i915/bios: fix printk format width

[Jani Nikula <jani.nikula@intel.com>]

On Thu, 05 Sep 2024, "Kulkarni, Vandita" <vandita.kulkarni@intel.com> wrote:
>> -----Original Message-----
>> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Jani
>> Nikula
>> Sent: Thursday, September 5, 2024 4:55 PM
>> To: intel-gfx@lists.freedesktop.org
>> Cc: Nikula, Jani <jani.nikula@intel.com>; stable@vger.kernel.org
>> Subject: [PATCH] drm/i915/bios: fix printk format width
>>
>> s/0x04%x/0x%04x/ to use 0 prefixed width 4 instead of printing 04 verbatim.
>>
>> Fixes: 51f5748179d4 ("drm/i915/bios: create fake child devices on missing
>> VBT")
>> Cc: <stable@vger.kernel.org> # v5.13+
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>
> LGTM.
> Reviewed-by: Vandita Kulkarni <vandita.kulkarni@intel.com>

Pushed to din, thanks for the review.

BR,
Jani.


>
> Thanks.
>>  drivers/gpu/drm/i915/display/intel_bios.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c
>> b/drivers/gpu/drm/i915/display/intel_bios.c
>> index cd32c9cd38a9..daa4b9535123 100644
>> --- a/drivers/gpu/drm/i915/display/intel_bios.c
>> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
>> @@ -2949,7 +2949,7 @@ init_vbt_missing_defaults(struct intel_display
>> *display)
>>               list_add_tail(&devdata->node, &display-
>> >vbt.display_devices);
>>
>>               drm_dbg_kms(display->drm,
>> -                         "Generating default VBT child device with type
>> 0x04%x on port %c\n",
>> +                         "Generating default VBT child device with type
>> 0x%04x on port
>> +%c\n",
>>                           child->device_type, port_name(port));
>>       }
>>
>> --
>> 2.39.2
>

-- 
Jani Nikula, Intel