From: Jani Nikula <jani.nikula@intel.com>
To: Thomas Zimmermann <tzimmermann@suse.de>, dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 0/8] drm: fix .get_modes() return values
Date: Wed, 13 Mar 2024 13:47:51 +0200 [thread overview]
Message-ID: <878r2ms68o.fsf@intel.com> (raw)
In-Reply-To: <f765ad88-d166-488c-a516-ccac462b6dbd@suse.de>
On Fri, 08 Mar 2024, Thomas Zimmermann <tzimmermann@suse.de> wrote:
> Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
>
> for the series.
Thanks, pushed the lot to drm-misc-next-fixes.
> Do you plan to make the return type an unsigned int eventually?
Not really. The hooks could still return -ENOMEM or something, with no
compiler warnings, and you'd be screwed because you wouldn't even have a
way of checking. You'd just get 4294967284 modes.
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2024-03-13 11:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 16:03 [PATCH 0/8] drm: fix .get_modes() return values Jani Nikula
2024-03-08 16:03 ` [PATCH 1/8] drm/probe-helper: warn about negative .get_modes() Jani Nikula
2024-03-08 16:03 ` [PATCH 2/8] drm/panel: do not return negative error codes from drm_panel_get_modes() Jani Nikula
2024-03-08 16:52 ` Jessica Zhang
2024-03-11 8:23 ` Neil Armstrong
2024-03-08 16:03 ` [PATCH 3/8] drm/exynos: do not return negative values from .get_modes() Jani Nikula
2024-03-08 16:03 ` [PATCH 4/8] drm/bridge: lt8912b: " Jani Nikula
2024-03-08 16:03 ` [PATCH 5/8] drm/imx/ipuv3: " Jani Nikula
2024-03-08 16:41 ` Philipp Zabel
2024-03-08 16:03 ` [PATCH 6/8] drm/vc4: hdmi: " Jani Nikula
2024-03-08 16:06 ` Maxime Ripard
2024-03-08 16:03 ` [PATCH 7/8] drm/bridge: lt9611uxc: use int for holding number of modes Jani Nikula
2024-03-11 8:28 ` Neil Armstrong
2024-03-11 9:18 ` Dmitry Baryshkov
2024-03-08 16:03 ` [PATCH 8/8] drm/exynos: simplify the return value handling in exynos_dp_get_modes() Jani Nikula
2024-03-08 16:24 ` [PATCH 0/8] drm: fix .get_modes() return values Thomas Zimmermann
2024-03-13 11:47 ` Jani Nikula [this message]
2024-03-08 18:25 ` ✗ Fi.CI.SPARSE: warning for " Patchwork
2024-03-08 18:30 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-03-12 0:28 ` ✗ Fi.CI.SPARSE: warning for drm: fix .get_modes() return values (rev2) Patchwork
2024-03-12 0:45 ` ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878r2ms68o.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).