From: "Keith Packard" <keithp@keithp.com>
To: DRI Development <dri-devel@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH 3/3] drm/lease: look at ->universal_planes only once
Date: Fri, 02 Nov 2018 08:04:32 -0700 [thread overview]
Message-ID: <878t2btta7.fsf@keithp.com> (raw)
In-Reply-To: <20181102132543.16486-3-daniel.vetter@ffwll.ch>
[-- Attachment #1.1: Type: text/plain, Size: 512 bytes --]
Daniel Vetter <daniel.vetter@ffwll.ch> writes:
> @@ -359,7 +359,8 @@ void drm_lease_revoke(struct drm_master *top)
> static int validate_lease(struct drm_device *dev,
> struct drm_file *lessor_priv,
> int object_count,
> - struct drm_mode_object **objects)
> + struct drm_mode_object **objects,
> + bool universal_planes)
It looks like you can remove the lessor_priv argument here, which would
ensure that we didn't reference any fields in it in the future.
--
-keith
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-11-02 15:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 13:25 [PATCH 1/3] drm/lease: debug output for lease creation Daniel Vetter
2018-11-02 13:25 ` [PATCH 2/3] drm/file: Uncompact the feature flags Daniel Vetter
2018-11-02 17:05 ` Chris Wilson
2018-11-02 13:25 ` [PATCH 3/3] drm/lease: look at ->universal_planes only once Daniel Vetter
2018-11-02 15:04 ` Keith Packard [this message]
2018-11-02 21:46 ` [PATCH] " Daniel Vetter
2018-11-05 10:12 ` Daniel Vetter
2018-11-06 17:23 ` Daniel Vetter
2018-11-02 14:18 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/lease: debug output for lease creation Patchwork
2018-11-02 14:36 ` ✓ Fi.CI.BAT: success " Patchwork
2018-11-02 15:02 ` [PATCH 1/3] " Keith Packard
2018-11-02 16:16 ` ✓ Fi.CI.IGT: success for series starting with [1/3] " Patchwork
2018-11-02 22:37 ` ✗ Fi.CI.BAT: failure for series starting with [1/3] drm/lease: debug output for lease creation (rev2) Patchwork
2018-11-05 10:26 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/lease: debug output for lease creation (rev3) Patchwork
2018-11-05 10:43 ` ✓ Fi.CI.BAT: success " Patchwork
2018-11-05 11:57 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-11-06 8:46 ` ✓ Fi.CI.IGT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878t2btta7.fsf@keithp.com \
--to=keithp@keithp.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox