From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Feng Tang <feng.tang@intel.com>,
alek.du@intel.com
Subject: Re: [RFC] i915: make the probe asynchronous
Date: Tue, 05 Jun 2018 10:41:04 +0300 [thread overview]
Message-ID: <878t7t7ka7.fsf@intel.com> (raw)
In-Reply-To: <20180604053219.2040-1-feng.tang@intel.com>
On Mon, 04 Jun 2018, Feng Tang <feng.tang@intel.com> wrote:
> i915 driver's probe is one of the longest of pci devices, which takes
> about hundreds of microseconds or more, make the probe async will help
> much on the kernel boot time, as different driver's probe can go async.
>
> This have been limited verified on several platforms of mine, don't
> know if it will have other side effects and drawbacks, so I would
> throw it out for reviews and comments, thanks
See the previous discussion [1].
BR,
Jani.
[1] http://mid.mail-archive.com/20180323083048.13327-1-chris@chris-wilson.co.uk
>
> Signed-off-by: Feng Tang <feng.tang@intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> drivers/gpu/drm/i915/i915_pci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> index 062e91b39085..5db3080101be 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -725,6 +725,7 @@ static struct pci_driver i915_pci_driver = {
> .probe = i915_pci_probe,
> .remove = i915_pci_remove,
> .driver.pm = &i915_pm_ops,
> + .driver.probe_type = PROBE_PREFER_ASYNCHRONOUS,
> };
>
> static int __init i915_init(void)
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-06-05 7:41 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-04 5:32 [RFC] i915: make the probe asynchronous Feng Tang
2018-06-04 6:27 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-06-04 7:18 ` ✓ Fi.CI.IGT: " Patchwork
2018-06-05 7:41 ` Jani Nikula [this message]
2018-06-05 7:51 ` [RFC] " Feng Tang
2018-06-05 8:18 ` Jani Nikula
2018-06-06 7:36 ` Feng Tang
2018-06-06 8:21 ` Jani Nikula
2018-06-20 6:25 ` Feng Tang
2018-06-20 6:35 ` Takashi Iwai
2018-06-20 6:47 ` Feng Tang
2018-06-20 7:11 ` Jani Nikula
2018-06-20 8:02 ` Daniel Vetter
2018-06-20 9:45 ` Takashi Iwai
2018-06-21 6:52 ` Feng Tang
2018-06-25 15:36 ` Daniel Vetter
2018-06-26 2:29 ` Feng Tang
2018-07-12 1:29 ` Feng Tang
2018-07-12 6:54 ` Daniel Vetter
2018-07-12 6:56 ` Takashi Iwai
2018-07-12 7:37 ` Daniel Vetter
2018-07-12 7:57 ` Feng Tang
2018-07-12 7:51 ` Feng Tang
2018-08-14 6:54 ` Feng Tang
2018-08-14 9:34 ` Daniel Vetter
2018-08-14 9:39 ` Takashi Iwai
2018-08-16 7:40 ` Feng Tang
2022-10-28 21:55 ` [Intel-gfx] " Brian Norris
2018-06-20 9:46 ` Feng Tang
2018-06-20 11:16 ` Jani Nikula
2018-06-20 6:37 ` ✗ Fi.CI.CHECKPATCH: warning for i915: make the probe asynchronous (rev2) Patchwork
2018-06-20 6:59 ` ✗ Fi.CI.BAT: failure " Patchwork
2018-06-20 9:58 ` ✗ Fi.CI.CHECKPATCH: warning for i915: make the probe asynchronous (rev3) Patchwork
2018-06-20 10:13 ` ✓ Fi.CI.BAT: success " Patchwork
2018-06-20 11:34 ` ✓ Fi.CI.IGT: " Patchwork
2018-07-12 9:03 ` ✗ Fi.CI.CHECKPATCH: warning for i915: make the probe asynchronous (rev4) Patchwork
2018-07-12 9:20 ` ✓ Fi.CI.BAT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878t7t7ka7.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=alek.du@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=feng.tang@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox