From: Jani Nikula <jani.nikula@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH] [CI] kernel: Downgrade warning for unsafe parameters
Date: Mon, 26 Feb 2018 12:59:58 +0200 [thread overview]
Message-ID: <878tbg2ez5.fsf@intel.com> (raw)
In-Reply-To: <151964194710.2350.8794546933293696139@mail.alporthouse.com>
On Mon, 26 Feb 2018, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Jani Nikula (2018-02-26 10:42:40)
>> On Tue, 20 Feb 2018, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>> > We make use of unsafe kernel parameters in igt, which generates a
>> > warning and taints the kernel. The warning is unhelpful as we then need
>> > to filter it out again, so kill it at source.
>>
>> Is your goal to upstream this or what?
>
> First asking if we see merit in this. If so, I can rewrite the commitmsg
> to emphasise that this is a direct result of user behaviour and so
> emitting a WARN is over the top. However, the counter argument is that
> this sets a kernel taint, so shouldn't it warn as well?
I erred on the side of ensuring the reason for tainting doesn't go
unnoticed when I added that. But I don't think the logging level was
ever discussed, it's just what I thought best at the time. I don't think
I care as long as it stays below debug level.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2018-02-26 10:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 17:18 [PATCH] [CI] kernel: Downgrade warning for unsafe parameters Chris Wilson
2018-02-20 17:21 ` Chris Wilson
2018-02-20 17:47 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2018-02-20 18:01 ` ✗ Fi.CI.BAT: " Patchwork
2018-02-26 10:42 ` [igt-dev] [PATCH] [CI] " Jani Nikula
2018-02-26 10:45 ` Chris Wilson
2018-02-26 10:59 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878tbg2ez5.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox