Re: [PATCH maintainer-tools v2] dim: Resist committing patches that modify files outside of i915

[Jani Nikula <jani.nikula@intel.com>]

On Tue, 10 May 2016, Joonas Lahtinen <joonas.lahtinen@linux.intel.com> wrote:
> If committing to drm-intel-next-queued branch, require the committer
> to be aware that they are committing outside of drm/i915 maintenance
> scope.
>
> v2:
> - Do not use warn_or_fail (Jani)
> - Only apply to drm-intel-next-queued branch (Daniel)
>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> ---
>  dim | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/dim b/dim
> index d9c1be5..cbdae85 100755
> --- a/dim
> +++ b/dim
> @@ -691,6 +691,17 @@ function checkpatch_commit
>  	if test "$bug_lines" -eq 1; then
>  		warn_or_fail "New BUG macro added"
>  	fi
> +
> +        if [ "$branch" = "drm-intel-next-queued" ]; then
> +		local non_i915_files=$(git diff-tree --no-commit-id --name-only -r HEAD | \

Using HEAD doesn't fly. dim checkpatch supports giving an arbitrary
commit range to check, and this function is given the commit to check as
parameter.

BR,
Jani.

> +			grep -v "^\(drivers/gpu/drm/i915/\|include/drm/i915\|include/uapi/drm/i915\)")
> +
> +		if [ -n "$non_i915_files" ]; then
> +			echo -e "The following files are outside of i915 maintenance scope:\n"
> +			echo "$non_i915_files"
> +			echo -e "\nConfirm you have appropriate Acked-by and Reviewed-by for above files."
> +		fi
> +	fi
>  }
>  
>  # turn $1 in to a git commit range

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx