From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH 3/5] drm/i915: vlv: fix save/restore of GFX_MAX_REQ_COUNT reg
Date: Wed, 18 Mar 2015 15:42:13 +0200 [thread overview]
Message-ID: <878ueumngq.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <1426538447-4819-4-git-send-email-rodrigo.vivi@intel.com>
Rodrigo Vivi <rodrigo.vivi@intel.com> writes:
> From: Imre Deak <imre.deak@intel.com>
>
> Due this typo we don't save/restore the GFX_MAX_REQ_COUNT register across
> suspend/resume, so fix this.
>
> This was introduced in
>
> commit ddeea5b0c36f3665446518c609be91f9336ef674
> Author: Imre Deak <imre.deak@intel.com>
> Date: Mon May 5 15:19:56 2014 +0300
>
> drm/i915: vlv: add runtime PM support
>
> I noticed this only by reading the code. To my knowledge it shouldn't
> cause any real problems at the moment, since the power well backing this
> register remains on across a runtime s/r. This may change once
> system-wide s0ix functionality is enabled in the kernel.
>
> v2:
> - resend after a missing git add -u :/
>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
> Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang.he@intel.com)
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 82f8be4..9cc953e 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -1038,7 +1038,7 @@ static void vlv_save_gunit_s0ix_state(struct drm_i915_private *dev_priv)
> s->lra_limits[i] = I915_READ(GEN7_LRA_LIMITS_BASE + i * 4);
>
> s->media_max_req_count = I915_READ(GEN7_MEDIA_MAX_REQ_COUNT);
> - s->gfx_max_req_count = I915_READ(GEN7_MEDIA_MAX_REQ_COUNT);
> + s->gfx_max_req_count = I915_READ(GEN7_GFX_MAX_REQ_COUNT);
>
> s->render_hwsp = I915_READ(RENDER_HWS_PGA_GEN7);
> s->ecochk = I915_READ(GAM_ECOCHK);
> @@ -1119,7 +1119,7 @@ static void vlv_restore_gunit_s0ix_state(struct drm_i915_private *dev_priv)
> I915_WRITE(GEN7_LRA_LIMITS_BASE + i * 4, s->lra_limits[i]);
>
> I915_WRITE(GEN7_MEDIA_MAX_REQ_COUNT, s->media_max_req_count);
> - I915_WRITE(GEN7_MEDIA_MAX_REQ_COUNT, s->gfx_max_req_count);
> + I915_WRITE(GEN7_GFX_MAX_REQ_COUNT, s->gfx_max_req_count);
>
> I915_WRITE(RENDER_HWS_PGA_GEN7, s->render_hwsp);
> I915_WRITE(GAM_ECOCHK, s->ecochk);
> --
> 2.1.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-03-18 13:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 20:40 [PATCH 0/5] drm-intel-collector - update Rodrigo Vivi
2015-03-16 20:40 ` [PATCH 1/5] drm/i915: Remove pinned check from madvise_ioctl Rodrigo Vivi
2015-03-16 20:40 ` [PATCH 2/5] drm/i915/vlv: check port in infoframe_enabled v2 Rodrigo Vivi
2015-03-16 20:40 ` [PATCH 3/5] drm/i915: vlv: fix save/restore of GFX_MAX_REQ_COUNT reg Rodrigo Vivi
2015-03-18 13:42 ` Mika Kuoppala [this message]
2015-03-16 20:40 ` [PATCH 4/5] drm/i915: Remove unused head member in request struct Rodrigo Vivi
2015-03-16 20:40 ` [PATCH 5/5] drm/i915: Remove unneeded check on execlist ringbuf alloc Rodrigo Vivi
2015-03-17 1:54 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878ueumngq.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox