From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
Cc: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>,
intel-gfx@lists.freedesktop.org,
Lucas De Marchi <lucas.demarchi@intel.com>,
Oded Gabbay <ogabbay@kernel.org>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH] drm/xe: Fix build without CONFIG_FAULT_INJECTION
Date: Mon, 18 Dec 2023 10:51:03 -0800 [thread overview]
Message-ID: <87a5q7uyy0.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <9ab982c2-f278-e54d-09b4-e6738c443dce@linux.intel.com>
On Mon, 18 Dec 2023 06:57:14 -0800, Thomas Hellström wrote:
>
>
> On 12/18/23 15:30, Rodrigo Vivi wrote:
> > Ideally this header could be included without the CONFIG_FAULT_INJECTION
> > and it would take care itself for the includes it needs.
> > So, let's temporary workaround this by moving this below and including
> > only when CONFIG_FAULT_INJECTION is selected to avoid build breakages.
> >
> > Another solution would be us including the linux/types.h as well, but
> > this creates unnecessary cases.
> >
> > Reference: https://lore.kernel.org/all/20230816134748.979231-1-himal.prasad.ghimiray@intel.com/
> > Cc: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
> > Cc: Oded Gabbay <ogabbay@kernel.org>
> > Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> > Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> LGTM.
>
> Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Hmm, msm/msm_drv.c doesn't seem to need to do this. Anyway maybe ok for a
temporary fix...
next prev parent reply other threads:[~2023-12-18 18:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 14:30 [PATCH] drm/xe: Fix build without CONFIG_FAULT_INJECTION Rodrigo Vivi
2023-12-18 14:57 ` Thomas Hellström
2023-12-18 18:51 ` Dixit, Ashutosh [this message]
2023-12-18 19:28 ` Rodrigo Vivi
2023-12-18 21:33 ` ✗ Fi.CI.BUILD: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5q7uyy0.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=himal.prasad.ghimiray@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=ogabbay@kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox