Re: [Intel-gfx] [PATCH v10 0/4] Add hwmon support for dgfx selftests

[Jani Nikula <jani.nikula@linux.intel.com>]

On Wed, 05 Apr 2023, Riana Tauro <riana.tauro@intel.com> wrote:
> Rename librapl library to libpower. Add hwmon support in libpower for
> dgfx.
> Use libpower in selftests.
>
> Rev2 : Update commit message
> Rev3 : Remove redundant code
> Rev4 : Add hwmon per-gt support
> Rev5 : No functional changes.
>        Change author for last patch
> Rev6 : re-order libpower library patch
>        add check for single gt in hwmon function
> Rev7 : Same as Rev 5 with a single gt check
>        in hwmon function
> Rev8 : Skip power comparison in live_rc6_manual for
>        discrete graphics
> Rev9 : Update commit message
> Rev10: No functional changes
>        Fix a spelling

Please do *not* send two revisions 15 minutes apart just to fix a
spelling error.

As a rule of thumb, for each revision, wait for review comments and test
results for at least a day. Usually longer. Don't accumulate a lot of
revisions for no benefit. It just causes extra work and
confusion. Rushing it does not pay off, on the contrary.

Now, you have review comments to v9 sent after v10 was out. You also
have both revisions in CI shards queue waiting to be tested, consuming
resources for no benefit. Based on the review comment there will be
another version; do not send it until you have figured out with the
reviewer what needs to be done and there's been enough time for people
to chime in.

In general, the revision log above shows a lot of new revisions for
non-functional changes. Don't do that until you have green light for the
functional changes, and the non-functional polish on top is just one
final version.


BR,
Jani.


>
> Riana Tauro (3):
>   drm/i915/selftests: Rename librapl library to libpower
>   drm/i915/hwmon: Add helper function to obtain energy values
>   drm/i915/selftests: skip comparison of power for discrete graphics
>
> Tilak Tangudu (1):
>   drm/i915/selftests: Add hwmon support in libpower for dgfx
>
>  drivers/gpu/drm/i915/Makefile             |  2 +-
>  drivers/gpu/drm/i915/gt/selftest_rc6.c    | 22 ++++++++++-----
>  drivers/gpu/drm/i915/gt/selftest_rps.c    | 26 ++++++++---------
>  drivers/gpu/drm/i915/gt/selftest_slpc.c   |  4 +--
>  drivers/gpu/drm/i915/i915_hwmon.c         | 28 +++++++++++++++++++
>  drivers/gpu/drm/i915/i915_hwmon.h         |  3 ++
>  drivers/gpu/drm/i915/selftests/libpower.c | 33 ++++++++++++++++++++++
>  drivers/gpu/drm/i915/selftests/libpower.h | 19 +++++++++++++
>  drivers/gpu/drm/i915/selftests/librapl.c  | 34 -----------------------
>  drivers/gpu/drm/i915/selftests/librapl.h  | 17 ------------
>  10 files changed, 114 insertions(+), 74 deletions(-)
>  create mode 100644 drivers/gpu/drm/i915/selftests/libpower.c
>  create mode 100644 drivers/gpu/drm/i915/selftests/libpower.h
>  delete mode 100644 drivers/gpu/drm/i915/selftests/librapl.c
>  delete mode 100644 drivers/gpu/drm/i915/selftests/librapl.h

-- 
Jani Nikula, Intel Open Source Graphics Center