Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Bump VBT version for expected child dev size check
Date: Mon, 06 Mar 2023 19:29:50 +0200	[thread overview]
Message-ID: <87a60pu6sx.fsf@intel.com> (raw)
In-Reply-To: <20230306154419.23207-1-ville.syrjala@linux.intel.com>

On Mon, 06 Mar 2023, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> The most modern VBT I've observed in the wild is version 250.
> The child dev size hasn't changed since version 216, so bump
> the version number in the expected child dev size check.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_bios.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
> index f16887aed56d..e54febd34ca9 100644
> --- a/drivers/gpu/drm/i915/display/intel_bios.c
> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
> @@ -2822,7 +2822,7 @@ parse_general_definitions(struct drm_i915_private *i915)
>  		expected_size = 37;
>  	} else if (i915->display.vbt.version <= 215) {
>  		expected_size = 38;
> -	} else if (i915->display.vbt.version <= 237) {
> +	} else if (i915->display.vbt.version <= 250) {
>  		expected_size = 39;
>  	} else {
>  		expected_size = sizeof(*child);

-- 
Jani Nikula, Intel Open Source Graphics Center

  reply	other threads:[~2023-03-06 17:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-06 15:44 [Intel-gfx] [PATCH] drm/i915: Bump VBT version for expected child dev size check Ville Syrjala
2023-03-06 17:29 ` Jani Nikula [this message]
2023-03-06 22:01 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2023-03-07 10:41 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a60pu6sx.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox