From: Jani Nikula <jani.nikula@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: use upstream version of header tests
Date: Tue, 30 Jul 2019 12:18:48 +0300 [thread overview]
Message-ID: <87a7cvop6v.fsf@intel.com> (raw)
In-Reply-To: <156447497813.6373.10937852267140257861@skylake-alporthouse-com>
On Tue, 30 Jul 2019, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Jani Nikula (2019-07-29 15:08:47)
>> Throw out our local hacks of header tests now that the more generic
>> kbuild versions are upstream.
>>
>> At least for now, continue to keep the header tests behind
>> CONFIG_DRM_I915_WERROR=y knob.
>>
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>>
>> ---
>>
>> Technically the upstream versions are only in drm-tip, and not in dinq
>> until a backmerge, but I think it's good enough. I don't think it should
>> mess anything up.
>> ---
>> drivers/gpu/drm/i915/Kconfig.debug | 1 +
>> drivers/gpu/drm/i915/Makefile | 2 +-
>> drivers/gpu/drm/i915/Makefile.header-test | 27 -------------------
>> drivers/gpu/drm/i915/display/Makefile | 3 ++-
>> .../gpu/drm/i915/display/Makefile.header-test | 16 -----------
>> drivers/gpu/drm/i915/gem/Makefile | 2 +-
>> drivers/gpu/drm/i915/gem/Makefile.header-test | 16 -----------
>> drivers/gpu/drm/i915/gt/Makefile | 2 +-
>> drivers/gpu/drm/i915/gt/Makefile.header-test | 16 -----------
>> drivers/gpu/drm/i915/gt/uc/Makefile | 2 +-
>> .../gpu/drm/i915/gt/uc/Makefile.header-test | 16 -----------
>
> Looks complete (must remember to not add i915/mm/Makefile.header-test)
>
>> 11 files changed, 7 insertions(+), 96 deletions(-)
>> delete mode 100644 drivers/gpu/drm/i915/Makefile.header-test
>> delete mode 100644 drivers/gpu/drm/i915/display/Makefile.header-test
>> delete mode 100644 drivers/gpu/drm/i915/gem/Makefile.header-test
>> delete mode 100644 drivers/gpu/drm/i915/gt/Makefile.header-test
>> delete mode 100644 drivers/gpu/drm/i915/gt/uc/Makefile.header-test
>>
>> diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug
>> index 4cdc0181a093..87a38c6aaa41 100644
>> --- a/drivers/gpu/drm/i915/Kconfig.debug
>> +++ b/drivers/gpu/drm/i915/Kconfig.debug
>> @@ -7,6 +7,7 @@ config DRM_I915_WERROR
>> # We use the dependency on !COMPILE_TEST to not be enabled in
>> # allmodconfig or allyesconfig configurations
>> depends on !COMPILE_TEST
>> + select HEADER_TEST
>
> I thought this should be a tab?
Me too, but none of the others around it were. :/
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Thanks, pushed to dinq.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2019-07-30 9:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 14:08 [PATCH] drm/i915: use upstream version of header tests Jani Nikula
2019-07-29 14:16 ` Chris Wilson
2019-07-29 14:33 ` Jani Nikula
2019-07-30 8:22 ` Jani Nikula
2019-07-29 16:26 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-07-29 16:55 ` ✓ Fi.CI.BAT: success " Patchwork
2019-07-30 2:10 ` ✓ Fi.CI.IGT: " Patchwork
2019-07-30 8:22 ` [PATCH] " Chris Wilson
2019-07-30 9:18 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7cvop6v.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox