Re: [PATCH v1 2/2] drm/xe: Modify the cfb size to be page size aligned for FBC

[Jani Nikula <jani.nikula@linux.intel.com>]

On Fri, 12 Jan 2024, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Wed, 10 Jan 2024, Vinod Govindapillai <vinod.govindapillai@intel.com> wrote:
>> drm_gem_private_object_init expect the object size be page size
>> aligned. The xe_bo create functions do not update the size for
>> any alignment requirements. So align cfb size to be page size
>> aligned in xe stolen memory handling.
>
> Please send this to the intel-xe mailing list.

Oh, and by "this" I mean this one patch. Patch 1 is mostly
non-functional cleanup.

>
> BR,
> Jani.
>
>
>>
>> Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
>> ---
>>  drivers/gpu/drm/xe/compat-i915-headers/i915_gem_stolen.h | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/xe/compat-i915-headers/i915_gem_stolen.h b/drivers/gpu/drm/xe/compat-i915-headers/i915_gem_stolen.h
>> index 888e7a87a925..bd233007c1b7 100644
>> --- a/drivers/gpu/drm/xe/compat-i915-headers/i915_gem_stolen.h
>> +++ b/drivers/gpu/drm/xe/compat-i915-headers/i915_gem_stolen.h
>> @@ -19,6 +19,9 @@ static inline int i915_gem_stolen_insert_node_in_range(struct xe_device *xe,
>>  	int err;
>>  	u32 flags = XE_BO_CREATE_PINNED_BIT | XE_BO_CREATE_STOLEN_BIT;
>>  
>> +	if (align)
>> +		size = ALIGN(size, align);
>> +
>>  	bo = xe_bo_create_locked_range(xe, xe_device_get_root_tile(xe),
>>  				       NULL, size, start, end,
>>  				       ttm_bo_type_kernel, flags);

-- 
Jani Nikula, Intel