From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: John.C.Harrison@Intel.com
Cc: Intel-GFX@Lists.FreeDesktop.Org, DRI-Devel@Lists.FreeDesktop.Org
Subject: Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/guc: Allow for very slow GuC loading
Date: Fri, 17 Mar 2023 15:33:39 -0700 [thread overview]
Message-ID: <87bkkrvwho.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20230316220632.3312218-3-John.C.Harrison@Intel.com>
On Thu, 16 Mar 2023 15:06:32 -0700, John.C.Harrison@Intel.com wrote:
>
> From: John Harrison <John.C.Harrison@Intel.com>
>
> A failure to load the GuC is occasionally observed where the GuC log
> actually showed that the GuC had loaded just fine. The implication
> being that the load just took ever so slightly longer than the 200ms
> timeout. Given that the actual time should be tens of milliseconds at
> the slowest, this should never happen. So far the issue has generally
> been caused by a bad IFWI resulting in low frequencies during boot
> (depsite the KMD requesting max frequency). However, the issue seems
> to happen more often than one would like.
>
> So a) increase the timeout so that the user still gets a working
> system even in the case of slow load. And b) report the frequency
> during the load to see if that is the case of the slow down.
>
> v2: Reduce timeout in non-debug builds, add references (Daniele)
>
> References: https://gitlab.freedesktop.org/drm/intel/-/issues/7931
> References: https://gitlab.freedesktop.org/drm/intel/-/issues/8060
> References: https://gitlab.freedesktop.org/drm/intel/-/issues/8083
> References: https://gitlab.freedesktop.org/drm/intel/-/issues/8136
> References: https://gitlab.freedesktop.org/drm/intel/-/issues/8137
> Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
Tested this on ATSM and saw the interrmittent GuC FW load timeouts
disappear:
Tested-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
next prev parent reply other threads:[~2023-03-17 22:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 22:06 [Intel-gfx] [PATCH v2 0/2] Improvements to GuC load failure handling John.C.Harrison
2023-03-16 22:06 ` [Intel-gfx] [PATCH v2 1/2] drm/i915/guc: Improve GuC load error reporting John.C.Harrison
2023-03-16 22:06 ` [Intel-gfx] [PATCH v2 2/2] drm/i915/guc: Allow for very slow GuC loading John.C.Harrison
2023-03-17 22:33 ` Dixit, Ashutosh [this message]
2023-03-22 21:14 ` Ceraolo Spurio, Daniele
2023-03-23 2:40 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Improvements to GuC load failure handling (rev3) Patchwork
2023-03-23 22:30 ` John Harrison
2023-03-23 2:40 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-03-23 2:52 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-03-23 22:29 ` John Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkkrvwho.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=DRI-Devel@Lists.FreeDesktop.Org \
--cc=Intel-GFX@Lists.FreeDesktop.Org \
--cc=John.C.Harrison@Intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox