Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
Subject: Re: [Intel-gfx] [PATCH 3/3] drm/i915: reimplement header test feature
Date: Thu, 02 Jan 2020 12:30:17 +0200	[thread overview]
Message-ID: <87blrmtakm.fsf@intel.com> (raw)
In-Reply-To: <157677483329.6469.18250205597696895684@skylake-alporthouse-com>

On Thu, 19 Dec 2019, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Jani Nikula (2019-12-19 15:56:52)
>> From: Masahiro Yamada <yamada.masahiro@socionext.com>
>> 
>> I implemented a small build rule in drivers/gpu/drm/i915/Makefile
>> without relying on the special header-test-y syntax that was removed in
>> commit fcbb8461fd23 ("kbuild: remove header compile test").
>> 
>> I excluded some headers from the test coverage. I hope somebody
>> intrested can take a closer look at them.
>> 
>> Dummy subdir Makefiles can be removed altogether as single target build
>> use case is now covered by commit 394053f4a4b3 ("kbuild: make single
>> targets work more correctly").
>> 
>> v2 by Jani:
>> - add selftests/i915_perf_selftests.h to no-header-test
>> - add .gitignore for *.hdrtest
>> 
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Whelp, I guess that explains why CI didn't tell me off for breaking the
> self-contained headers. The pattern matching works, I didn't see any
> residue after a make clean, and git status is not swamped with the
> artifacts. Single object build still works. O=_build still works
> (O=_build -j10 did not, hopefully that is not significant???)

I couldn't reproduce any issues with parallel out-of-tree
builds. Fingers crossed.

> Everything looks (mostly) in order,
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Thanks, pushed.

BR,
Jani.


> -Chris
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2020-01-02 10:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-19 15:56 [Intel-gfx] [PATCH 1/3] drm/i915/selftests: make mock_context.h self-contained Jani Nikula
2019-12-19 15:56 ` [Intel-gfx] [PATCH 2/3] drm/i915/selftests: make mock_drm.h self-contained Jani Nikula
2019-12-19 16:17   ` Chris Wilson
2019-12-19 15:56 ` [Intel-gfx] [PATCH 3/3] drm/i915: reimplement header test feature Jani Nikula
2019-12-19 17:00   ` Chris Wilson
2020-01-02 10:30     ` Jani Nikula [this message]
2019-12-19 16:17 ` [Intel-gfx] [PATCH 1/3] drm/i915/selftests: make mock_context.h self-contained Chris Wilson
2019-12-19 16:54 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] " Patchwork
2019-12-19 17:37 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2019-12-20  6:05 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/selftests: make mock_context.h self-contained (rev2) Patchwork
2019-12-20  6:34 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2019-12-21 10:26 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87blrmtakm.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox