From: Jani Nikula <jani.nikula@linux.intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/bios: remove extra debug messages
Date: Mon, 09 Dec 2019 11:58:57 +0200 [thread overview]
Message-ID: <87blsh6cri.fsf@intel.com> (raw)
In-Reply-To: <20191206190552.8818-1-lucas.demarchi@intel.com>
On Fri, 06 Dec 2019, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> Just like in 523e0cc89b83 ("drm/i915/tgl: allow DVI/HDMI on port A"),
> the port checks when reading the VBT can easily not match what the
> platform really exposes. However here we only have some additional debug
> messages that are not adding much value: in the previous debug message
> we already print everything we know about the VBT.
>
> Instead of keep fixing the possible port assignments according to the
> platform, just nuke the additional messages.
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Ville
Acked-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_bios.c | 16 ----------------
> 1 file changed, 16 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
> index 1aeecdd02293..e054e87eba8e 100644
> --- a/drivers/gpu/drm/i915/display/intel_bios.c
> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
> @@ -1602,22 +1602,6 @@ static void parse_ddi_port(struct drm_i915_private *dev_priv,
> HAS_LSPCON(dev_priv) && child->lspcon,
> info->supports_typec_usb, info->supports_tbt);
>
> - if (is_edp && is_dvi)
> - DRM_DEBUG_KMS("Internal DP port %c is TMDS compatible\n",
> - port_name(port));
> - if (is_crt && port != PORT_E)
> - DRM_DEBUG_KMS("Port %c is analog\n", port_name(port));
> - if (is_crt && (is_dvi || is_dp))
> - DRM_DEBUG_KMS("Analog port %c is also DP or TMDS compatible\n",
> - port_name(port));
> - if (is_dvi && (port == PORT_A || port == PORT_E))
> - DRM_DEBUG_KMS("Port %c is TMDS compatible\n", port_name(port));
> - if (!is_dvi && !is_dp && !is_crt)
> - DRM_DEBUG_KMS("Port %c is not DP/TMDS/CRT compatible\n",
> - port_name(port));
> - if (is_edp && (port == PORT_B || port == PORT_C || port == PORT_E))
> - DRM_DEBUG_KMS("Port %c is internal DP\n", port_name(port));
> -
> if (is_dvi) {
> u8 ddc_pin;
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2019-12-09 9:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 19:05 [Intel-gfx] [PATCH] drm/i915/bios: remove extra debug messages Lucas De Marchi
2019-12-06 21:01 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-12-06 21:21 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2019-12-06 22:28 ` [Intel-gfx] [PATCH] " Matt Roper
2019-12-07 10:57 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
2019-12-09 9:58 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blsh6cri.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox