From: Jani Nikula <jani.nikula@intel.com>
To: Simon Ser <contact@emersion.fr>
Cc: intel-gfx@lists.freedesktop.org,
Lucas De Marchi <lucas.demarchi@intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [Intel-gfx] [PATCH] i915/display/hotplug: use drm_kms_helper_connector_hotplug_event()
Date: Wed, 21 Jun 2023 15:26:46 +0300 [thread overview]
Message-ID: <87cz1p2e7t.fsf@intel.com> (raw)
In-Reply-To: <jsOhDAQlffGFG9HskNzjr0CpzEbtI7nYIKOYHX50JgeYjM4-GeAeLo4m2qEcvf48WD4hga3N9gGR-CVkisL0izawz1L2w-msofkhYHvQ76k=@emersion.fr>
On Wed, 21 Jun 2023, Simon Ser <contact@emersion.fr> wrote:
> On Wednesday, June 21st, 2023 at 14:11, Jani Nikula <jani.nikula@intel.com> wrote:
>
>> On Wed, 21 Jun 2023, Simon Ser contact@emersion.fr wrote:
>>
>> > On Wednesday, June 21st, 2023 at 14:05, Jani Nikula jani.nikula@intel.com wrote:
>> >
>> > > > - if (changed)
>> > > > + if (hweight32(changed) == 1)
>> > > > + drm_kms_helper_connector_hotplug_event(first_changed_connector);
>> > >
>> > > What if more than one connector share the same hpd pin?
>> >
>> > Ah, I did not believe this could happen. I'll rework the patch to
>> > count the number of changed connectors instead.
>>
>> A DP++ port is probably the prime example of this, with both DP and HDMI
>> connectors.
>
> Wouldn't that be handled by the separate DP logic though? (The
> drm_dp_mst family of helpers.)
It's not DP MST, though. See intel_ddi_init() initializing both DP and
HDMI. One encoder, one HPD pin, two connectors.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2023-06-21 12:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 18:12 [Intel-gfx] [PATCH] i915/display/hotplug: use drm_kms_helper_connector_hotplug_event() Simon Ser
2023-06-21 0:03 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2023-06-21 9:17 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-06-21 12:05 ` [Intel-gfx] [PATCH] " Jani Nikula
2023-06-21 12:07 ` Simon Ser
2023-06-21 12:11 ` Jani Nikula
2023-06-21 12:14 ` Simon Ser
2023-06-21 12:26 ` Jani Nikula [this message]
2023-06-23 8:36 ` Simon Ser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cz1p2e7t.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=contact@emersion.fr \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox