From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Anshuman Gupta <anshuman.gupta@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/rps: Centralize computation of freq caps
Date: Wed, 06 Apr 2022 12:22:07 -0700 [thread overview]
Message-ID: <87czhudnkw.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20220406100944.GE22062@intel.com>
On Wed, 06 Apr 2022 03:09:45 -0700, Anshuman Gupta wrote:
> On 2022-03-24 at 01:24:35 +0530, Ashutosh Dixit wrote:
> > +/* "Caps" frequencies should be converted to MHz using intel_gpu_freq() */
> IMHO, if this exported function deserves a comment, it should Kernel Doc comment.
> for an example see Doc comment of intel_runtime_pm_get_raw().
> Thanks,
> Anshuman Gupta.
> > +void gen6_rps_get_freq_caps(struct intel_rps *rps, struct intel_rps_freq_caps *caps)
I have changed the comments to kernel doc for both gen6_rps_get_freq_caps()
and 'struct intel_rps_freq_caps' in v5 (v6 in Patchwork). Please take a
look. Thanks.
next prev parent reply other threads:[~2022-04-06 19:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-23 19:54 [Intel-gfx] [PATCH] drm/i915/rps: Centralize computation of freq caps Ashutosh Dixit
2022-03-23 20:59 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/rps: Centralize computation of freq caps (rev4) Patchwork
2022-03-23 21:03 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2022-03-23 21:25 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-03-29 3:59 ` [Intel-gfx] [PATCH] drm/i915/rps: Centralize computation of freq caps Nilawar, Badal
2022-04-02 4:13 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/rps: Centralize computation of freq caps (rev5) Patchwork
2022-04-02 4:50 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-04-02 6:27 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-04-06 10:09 ` [Intel-gfx] [PATCH] drm/i915/rps: Centralize computation of freq caps Anshuman Gupta
2022-04-06 19:22 ` Dixit, Ashutosh [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-04-06 19:18 Ashutosh Dixit
2022-04-07 13:22 ` Gupta, Anshuman
2022-03-22 21:06 Ashutosh Dixit
2022-03-22 18:56 Ashutosh Dixit
2022-03-23 7:03 ` Nilawar, Badal
2022-03-23 19:56 ` Dixit, Ashutosh
2022-03-21 17:56 Ashutosh Dixit
2022-03-21 18:17 ` Lucas De Marchi
2022-03-21 19:12 ` Dixit, Ashutosh
2022-03-22 18:55 ` Dixit, Ashutosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czhudnkw.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=anshuman.gupta@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox