From: Jani Nikula <jani.nikula@intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 1/7] drm/i915/reset: remove useless intel_display_types.h include
Date: Thu, 09 Dec 2021 21:17:08 +0200 [thread overview]
Message-ID: <87czm537wr.fsf@intel.com> (raw)
In-Reply-To: <YbI88n/N1Fq3nD2z@intel.com>
On Thu, 09 Dec 2021, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Thu, Dec 09, 2021 at 03:50:56PM +0200, Jani Nikula wrote:
>> Not needed.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>> drivers/gpu/drm/i915/gt/intel_reset.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gt/intel_reset.c b/drivers/gpu/drm/i915/gt/intel_reset.c
>> index 63199f0550e6..b8ac454f2d96 100644
>> --- a/drivers/gpu/drm/i915/gt/intel_reset.c
>> +++ b/drivers/gpu/drm/i915/gt/intel_reset.c
>> @@ -6,7 +6,6 @@
>> #include <linux/sched/mm.h>
>> #include <linux/stop_machine.h>
>>
>> -#include "display/intel_display_types.h"
>
> intel_display_{prepare,finish}_reset() are in intel_display.h
> so I'm thinking that is what we want to include here. I guess
> atm it gets included via some more circuitous route?
Mmmh, all roads lead to i915_drv.h...
We should trim the includes in i915_drv.h a *lot* too. Make it purely
about defining struct drm_i915_private, not about including the world.
It's just that especially the gem/gt headers include just about
everything.
BR,
Jani.
>
>> #include "display/intel_overlay.h"
>>
>> #include "gem/i915_gem_context.h"
>> --
>> 2.30.2
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2021-12-09 19:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 13:50 [Intel-gfx] [PATCH 0/7] drm/i915: include reductions Jani Nikula
2021-12-09 13:50 ` [Intel-gfx] [PATCH 1/7] drm/i915/reset: remove useless intel_display_types.h include Jani Nikula
2021-12-09 17:29 ` Ville Syrjälä
2021-12-09 19:17 ` Jani Nikula [this message]
2021-12-09 13:50 ` [Intel-gfx] [PATCH 2/7] drm/i915/active: remove useless i915_utils.h include Jani Nikula
2021-12-09 13:50 ` [Intel-gfx] [PATCH 3/7] drm/i915/psr: avoid intel_frontbuffer.h include with declaration Jani Nikula
2021-12-09 13:50 ` [Intel-gfx] [PATCH 4/7] drm/i915/fbc: " Jani Nikula
2021-12-09 13:51 ` [Intel-gfx] [PATCH 5/7] drm/i915/fb: reduce include dependencies Jani Nikula
2021-12-09 13:51 ` [Intel-gfx] [PATCH 6/7] drm/i915/pxp: un-inline intel_pxp_is_enabled() Jani Nikula
2021-12-09 13:51 ` [Intel-gfx] [PATCH 7/7] drm/i915/pxp: remove useless includes Jani Nikula
2021-12-09 17:32 ` [Intel-gfx] [PATCH 0/7] drm/i915: include reductions Ville Syrjälä
2021-12-10 2:15 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for " Patchwork
2021-12-10 13:03 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czm537wr.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox