From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/5] drm/i915: Make the hexdump row offset visually distinct
Date: Thu, 14 Jun 2018 18:16:31 +0300 [thread overview]
Message-ID: <87d0wtwg8g.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20180613145901.29306-3-chris@chris-wilson.co.uk>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> Currently we use %08x for the row offset, and %08x for the binary
> contents of the buffer. This makes it very easily to confuse the two, so
> switch to using [%04x] for the start-of-row offset.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_engine_cs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c b/drivers/gpu/drm/i915/intel_engine_cs.c
> index d7f757fb8401..875bd466f3bf 100644
> --- a/drivers/gpu/drm/i915/intel_engine_cs.c
> +++ b/drivers/gpu/drm/i915/intel_engine_cs.c
> @@ -1258,7 +1258,7 @@ static void hexdump(struct drm_printer *m, const void *buf, size_t len)
> rowsize, sizeof(u32),
> line, sizeof(line),
> false) >= sizeof(line));
> - drm_printf(m, "%08zx %s\n", pos, line);
> + drm_printf(m, "[%04zx] %s\n", pos, line);
>
> prev = buf + pos;
> skip = false;
> --
> 2.17.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-06-14 15:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 14:58 [PATCH 1/5] drm/i915: Supply the extended state flags for forced context load Chris Wilson
2018-06-13 14:58 ` [PATCH 2/5] drm/i915: Dump the ringbuffer of the active request for debugging Chris Wilson
2018-06-14 15:13 ` Mika Kuoppala
2018-06-13 14:58 ` [PATCH 3/5] drm/i915: Make the hexdump row offset visually distinct Chris Wilson
2018-06-14 15:16 ` Mika Kuoppala [this message]
2018-06-13 14:59 ` [PATCH 4/5] drm/i915: Show CCID in engine dumps Chris Wilson
2018-06-14 15:21 ` Mika Kuoppala
2018-06-13 14:59 ` [PATCH 5/5] drm/i915/gtt: Only keep gen6 page directories pinned while active Chris Wilson
2018-06-13 15:36 ` ✗ Fi.CI.BAT: failure for series starting with [1/5] drm/i915: Supply the extended state flags for forced context load Patchwork
-- strict thread matches above, loose matches on Subject: below --
2018-06-14 9:40 [PATCH 1/5] drm/i915: Move GEM sanitize from resume_early to resume Chris Wilson
2018-06-14 9:41 ` [PATCH 3/5] drm/i915: Make the hexdump row offset visually distinct Chris Wilson
2018-06-14 12:11 ` Joonas Lahtinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0wtwg8g.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox