Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	Anna Karas <anna.karas@intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] Docs: fix incorrect use of kernel-doc format in structure description.
Date: Thu, 19 Sep 2019 15:21:39 +0300	[thread overview]
Message-ID: <87ef0cwk6k.fsf@intel.com> (raw)
In-Reply-To: <156889085021.31102.6352117172373478689@skylake-alporthouse-com>

On Thu, 19 Sep 2019, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Anna Karas (2019-09-19 11:49:28)
>> Insert structure members names into their descriptions to follow
>> kernel-doc format
>> 
>> Signed-off-by: Anna Karas <anna.karas@intel.com>
>
> Lgtm, 
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Yes, apart from subject prefix. Maybe something like "drm/i915/perf: "
would be more accurate.

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-09-19 12:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-19 10:49 [PATCH] Docs: fix incorrect use of kernel-doc format in structure description Anna Karas
2019-09-19 11:00 ` Chris Wilson
2019-09-19 12:21   ` Jani Nikula [this message]
2019-09-19 12:17 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-09-19 19:18 ` ✓ Fi.CI.IGT: " Patchwork
2019-09-20  9:47 ` [PATCH] drm/i915/perf: Fix use of kernel-doc format in structure members Anna Karas
2019-09-20 10:17   ` Lionel Landwerlin
2019-09-20 14:20 ` ✓ Fi.CI.BAT: success for Docs: fix incorrect use of kernel-doc format in structure description. (rev2) Patchwork
2019-09-21 12:20 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ef0cwk6k.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=anna.karas@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox